Closed haircommander closed 2 weeks ago
/retest
/retest
/retest
@haircommander do we have a Jira/other way today to tag all related PRs for this effort in a single place? so it's easy for ourselves later in time or for others with less context to catch up? E.g Add minimumKubeletVersion knob and validation epic involves https://github.com/openshift/hypershift/pull/4980 https://github.com/openshift/kubernetes/pull/2104 https://github.com/openshift/api/pull/2059
@enxebre there's also https://github.com/openshift/library-go/pull/1831 and https://github.com/openshift/cluster-kube-apiserver-operator/pull/1754
the overarching epic is https://issues.redhat.com/browse/OCPNODE-2506. Note a number of the cards tracking these PRs are closed because they were originally scoped to drafts for the work until I got feedback and could size the time to respond
thanks @enxebre @JoelSpeed I've updated for your comments, PTAL :slightly_smiling_face:
/retest
/retest
@JoelSpeed @enxebre any other thoughts?
/retest
/lgtm
Thanks @haircommander
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: haircommander, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/retest-required
Remaining retests: 0 against base HEAD ddd439f6a2f9b8741dc35fef6bce5c16095edea8 and 2 for PR HEAD 808d8814f38a1eaa4491c42d62274c6577abe880 in total
@haircommander: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-azure | 808d8814f38a1eaa4491c42d62274c6577abe880 | link | false | /test e2e-azure |
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202411012108.p0.g04eb3fd.assembly.stream.el9. All builds following this will include this PR.
Hello @haircommander! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.