Closed JoelSpeed closed 1 month ago
Hello @JoelSpeed! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@JoelSpeed: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: enxebre, JoelSpeed
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Without passing this field into the new generator options, the flag is redundant. That's ok for o/api but when trying to use this with the feature gate at a different path, it's not presently working.