search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

SPLAT-1851: Make VSphereMultiVCenters feature gate GA #2063

Open vr4manta opened 1 month ago

vr4manta commented 1 month ago

SPLAT-1851

Changes

E2E Test Data:

openshift-ci-robot commented 1 month ago

@vr4manta: This pull request references SPLAT-1851 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2063): >[SPLAT-1851](https://issues.redhat.com//browse/SPLAT-1851) > >### Changes >- Promoted VSphereMultiVCenters feature gate to GA (default) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

Hello @vr4manta! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 1 month ago

@vr4manta: This pull request references SPLAT-1851 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2063): >[SPLAT-1851](https://issues.redhat.com//browse/SPLAT-1851) > >### Changes >- Promoted VSphereMultiVCenters feature gate to GA (default) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vr4manta Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
vr4manta commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@vr4manta: This pull request references SPLAT-1851 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2063#issuecomment-2414560619): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@vr4manta: This pull request references SPLAT-1851 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2063): >[SPLAT-1851](https://issues.redhat.com//browse/SPLAT-1851) > >### Changes >- Promoted VSphereMultiVCenters feature gate to GA (default) > >### E2E Test Data: >- This feature gets tested by the [Periodical jobs](https://github.com/openshift/release/blob/09ae0b613da36e3ed3fd95e0bcae55ea235c5be5/ci-operator/config/openshift/release/openshift-release-master__nightly-4.18.yaml#L588) > - IPI > - https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-multi-vcenter > - https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter > - UPI > - https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-upi-multi-vcenter > - https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-upi-multi-vcenter >- There isn't an origin E2E test for this feature, so I expect the verify job automation to fail. We will require manual [QE Signoff](https://github.com/openshift/enhancements/blob/master/dev-guide/featuresets.md#obtaining-qe-sign-off) > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vr4manta commented 1 week ago

/retest

openshift-ci[bot] commented 1 week ago

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial 6dcd14dea7ea321ab6c079bf4765dfea205ffb80 link true /test e2e-aws-serial
ci/prow/e2e-aws-serial-techpreview 6dcd14dea7ea321ab6c079bf4765dfea205ffb80 link true /test e2e-aws-serial-techpreview
ci/prow/verify 6dcd14dea7ea321ab6c079bf4765dfea205ffb80 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
vr4manta commented 1 week ago

/assign @JoelSpeed Can I get approval and the override to skip the verify for missing e2e since we should be good w/ our current tests and the periodicals? Thanks!

openshift-ci-robot commented 1 week ago

@vr4manta: This pull request references SPLAT-1851 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2063): >[SPLAT-1851](https://issues.redhat.com//browse/SPLAT-1851) > >### Changes >- Promoted VSphereMultiVCenters feature gate to GA (default) > >### E2E Test Data: >- This feature gets tested by the [Periodical jobs](https://github.com/openshift/release/blob/09ae0b613da36e3ed3fd95e0bcae55ea235c5be5/ci-operator/config/openshift/release/openshift-release-master__nightly-4.18.yaml#L588) > - IPI > - https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-multi-vcenter > - https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter > - UPI > - https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-upi-multi-vcenter > - https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-upi-multi-vcenter >- There isn't an origin E2E test for this feature, so I expect the verify job automation to fail. We will require manual [QE Signoff](https://github.com/openshift/enhancements/blob/master/dev-guide/featuresets.md#obtaining-qe-sign-off) >- Created New pre-submits to help catch issues > - https://github.com/openshift/release/pull/58794 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
xueqzhan commented 3 days ago

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter

openshift-ci[bot] commented 3 days ago

@xueqzhan: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/a637b880-a5e8-11ef-9da0-8bd06e4934ae-0

gnufied commented 3 days ago

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter

openshift-ci[bot] commented 3 days ago

@gnufied: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1fdd5490-a609-11ef-8397-1ec89a976923-0

duanwei33 commented 3 days ago

QE also have CI against vsphere-ipi-multi-vcenter, the storage regression test result looks good. (Although we need a fix in our auto code in some snapshot cases) https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-vsphere-ipi-multi-vcenter-f28 https://qe-private-deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/qe-private-deck/logs/periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-vsphere-ipi-multi-vcenter-f28

From the storage part, we are good on the feature.

vr4manta commented 2 days ago

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter 3

openshift-ci[bot] commented 2 days ago

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/190c4bd0-a677-11ef-91f0-c873adae0d14-0

vr4manta commented 2 days ago

/payload-job periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter /payload-job periodic-ci-openshift-release-master-nightly-4.17-e2e-vsphere-ovn-multi-vcenter

openshift-ci[bot] commented 2 days ago

@vr4manta: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bfa88570-a67d-11ef-86fd-cd662d920139-0

vr4manta commented 2 days ago

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter 3

openshift-ci[bot] commented 2 days ago

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f06faf00-a68f-11ef-93af-9dea9fa5bdf7-0

vr4manta commented 2 days ago

/payload-aggregate periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-multi-vcenter 6

openshift-ci[bot] commented 2 days ago

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/52bd6d70-a6a7-11ef-8a09-c55179463a75-0

deads2k commented 14 hours ago

Updating here so it's in multiple places. 2/3 of attempts using this functionality on periodic-ci-openshift-release-master-nightly-4.18-e2e-vsphere-ovn-upi-multi-vcenter have failed this week on PVC related tests. 33% success does not meet our quality bar. We need to see 95% success prior to merge.

The IPI jobs are failing on the too many watches and removed API checks.