search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

OPRUN-3588: Add OperatorLifecycleManagerV1 cluster version capability #2066

Closed perdasilva closed 1 week ago

perdasilva commented 1 month ago

Preconditions:

Changes:

Next PR: openshift/cluster-olm-operator#74

openshift-ci[bot] commented 1 month ago

Hello @perdasilva! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 1 month ago

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2066): >Adds the 'OperatorLifecycleManagerV1' cluster capability Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2066): >Precondition: #2061 merged >Adds the 'OperatorLifecycleManagerV1' cluster capability Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2066): >Preconditions: > - [ ] #2061 merged > >Changes: > * Adds the 'OperatorLifecycleManagerV1' cluster capability Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2066): >Preconditions: > - [ ] #2061 merged > >Changes: > * Adds the 'OperatorLifecycleManagerV1' cluster capability > >Next PR: >* [openshift/cluster-olm-operator#74](https://github.com/openshift/cluster-olm-operator/pull/74) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2066): >Preconditions: > - [ ] #2061 merged > >Changes: > * Adds the 'OperatorLifecycleManagerV1' cluster capability > >Next PR: [openshift/cluster-olm-operator#74](https://github.com/openshift/cluster-olm-operator/pull/74) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
perdasilva commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2066#issuecomment-2446191315): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2066): >Preconditions: > - [ ] #2061 merged > >Changes: > * Adds the 'OLMv1' cluster capability > >Next PR: [openshift/cluster-olm-operator#74](https://github.com/openshift/cluster-olm-operator/pull/74) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
joelanford commented 2 weeks ago

/lgtm

openshift-ci-robot commented 2 weeks ago

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2066): >Preconditions: > - [x] #2061 merged > >Changes: > * Adds the 'OLMv1' cluster capability > >Next PR: [openshift/cluster-olm-operator#74](https://github.com/openshift/cluster-olm-operator/pull/74) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@perdasilva: This pull request references OPRUN-3588 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2066): >Preconditions: > - [x] #2061 merged > >Changes: > * Adds the 'OperatorLifecycleManagerV1' cluster capability > >Next PR: [openshift/cluster-olm-operator#74](https://github.com/openshift/cluster-olm-operator/pull/74) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
joelanford commented 1 week ago

/lgtm

deads2k commented 1 week ago

/approve

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, joelanford, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 week ago

@perdasilva: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 week ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202411090037.p0.ge22f17d.assembly.stream.el9. All builds following this will include this PR.