search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

Last generation only increase #2068

Closed bertinatto closed 1 month ago

bertinatto commented 1 month ago

Add a comment about validation for GenerationStatus.LastGeneration field (originally this PR added the validation itself, but we need to use a different approach and we'll do that later on).

/assign @deads2k @p0lyn0mial @JoelSpeed

openshift-ci[bot] commented 1 month ago

Hello @bertinatto! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

JoelSpeed commented 1 month ago

I'm not super familiar with the usage of this field, but it appears to track the observed generation of some resource related to the operator in some way.

What happens if a user comes along and deletes the related resource? The operator I'm guessing (or maybe something else) creates a new copy of the resource? At that point, the generation would go down wouldn't it?

/hold while we work this out

bertinatto commented 1 month ago

I'm not super familiar with the usage of this field, but it appears to track the observed generation of some resource related to the operator in some way.

What happens if a user comes along and deletes the related resource? The operator I'm guessing (or maybe something else) creates a new copy of the resource? At that point, the generation would go down wouldn't it?

/hold while we work this out

@JoelSpeed good point. I talked to David offline and we agreed on a different approach, to be implemented later on. For now we'll just add a comment to the field describing that. PTAL and let me know if it looks to be in the right format.

p0lyn0mial commented 1 month ago

/lgtm

JoelSpeed commented 1 month ago

/lgtm

The idea for the future path forward works for me

JoelSpeed commented 1 month ago

/hold cancel

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, JoelSpeed, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410181110.p0.g4f6053f.assembly.stream.el9. All builds following this will include this PR.