Open enxebre opened 1 month ago
Hello @enxebre! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: enxebre Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@enxebre: all tests passed!
Full PR test history. Your PR dashboard.
This seems to match the original proposal https://github.com/openshift/enhancements/pull/1605/files#diff-c3558e7ce5705e060c3f6ccbbf7430be6fe4dac2b8bad05220360bd977f81e70R214, recomendations and consistency with the rest of this API. The reason I came across this is that hypershift seralizes this API and use that as input to generate a hash that now transparently changes. While that fundamental problem is solved this will happen to buy hypershift some time.