Closed deads2k closed 4 weeks ago
Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
@deads2k: This pull request explicitly references no jira issue.
/approve I've made a suggested edit to the FeatureGate FAQ to align it a bit closer to the guidance that enhancements become necessary whenever we start involving more than one team in implementation or design.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: deads2k, sdodson
The full list of commands accepted by this bot can be found here.
The pull request process is described here
LGTM pending Mrunal's suggestion
We have agreement, labeling so we get CI assistance quickly.
@deads2k: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410231641.p0.g8a37acc.assembly.stream.el9. All builds following this will include this PR.
This doesn't (yet), mean the PR must be merged, but it does mean the PR needs to be open and GA graduation criteria need to be present. Typically GA criteria include
/cc @JoelSpeed /assign @sdodson @mrunalp