openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

NO-JIRA: add requirement for featuregate URL #2073

Closed deads2k closed 4 weeks ago

deads2k commented 1 month ago

This doesn't (yet), mean the PR must be merged, but it does mean the PR needs to be open and GA graduation criteria need to be present. Typically GA criteria include

  1. which automated tests must exist so we know it works
  2. how will we monitor this to ensure it functions correctly after we ship
  3. what additional information needs to be present in must-gather to debug this

/cc @JoelSpeed /assign @sdodson @mrunalp

openshift-ci[bot] commented 1 month ago

Hello @deads2k! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 1 month ago

@deads2k: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/api/pull/2073): >This doesn't (yet), mean the PR must be merged, but it does mean the PR needs to be open and GA graduation criteria need to be present. Typically GA criteria include >1. which automated tests must exist so we know it works >2. how will we monitor this to ensure it functions correctly after we ship >3. what additional information needs to be present in must-gather to debug this > >/cc @JoelSpeed >/assign @sdodson @mrunalp Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 1 month ago

/approve I've made a suggested edit to the FeatureGate FAQ to align it a bit closer to the guidance that enhancements become necessary whenever we start involving more than one team in implementation or design.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoelSpeed commented 4 weeks ago

LGTM pending Mrunal's suggestion

deads2k commented 4 weeks ago

We have agreement, labeling so we get CI assistance quickly.

openshift-ci[bot] commented 4 weeks ago

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 4 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410231641.p0.g8a37acc.assembly.stream.el9. All builds following this will include this PR.