search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

SPLAT-1743: Add VMGroup to VSphere Provider workspace #2074

Open jcpowermac opened 1 month ago

jcpowermac commented 1 month ago

Changes

For the machine api operator to support vm-host based zonal a single new field of vmGroup needs to be added that will indicate the vCenter cluster group to add a newly created virtual machine into.

Additional PRs

openshift-ci[bot] commented 1 month ago

Hello @jcpowermac! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 1 month ago

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2074): >For the machine api operator to support >vm-host based zonal a single new field of >`vmGroup` needs to be added that will indicate >the vCenter cluster group to add a newly created >virtual machine into. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2074): >### Changes > >For the machine api operator to support >vm-host based zonal a single new field of >`vmGroup` needs to be added that will indicate >the vCenter cluster group to add a newly created >virtual machine into. > >### Additional PRs > > > >- https://github.com/openshift/enhancements/pull/1677 >- https://github.com/openshift/installer/pull/8873 >- https://github.com/openshift/client-go/pull/294 >- https://github.com/openshift/library-go/pull/1782 >- https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325 >- https://github.com/openshift/machine-api-operator/pull/1285 >- https://github.com/openshift/api/pull/1999 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jcpowermac commented 1 week ago

/assign @JoelSpeed

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jcpowermac Once this PR has been reviewed and has the lgtm label, please ask for approval from joelspeed. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcpowermac commented 13 hours ago

@JoelSpeed updated

openshift-ci[bot] commented 12 hours ago

@jcpowermac: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 6398ee4c988e1d398e74d769ff9799413bc7bf77 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).