openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

Add changes to infrastructure object to contain service endpoints and feature flag added #2078

Open jared-hayes-dev opened 3 weeks ago

jared-hayes-dev commented 3 weeks ago

Related Jira: https://issues.redhat.com/browse/OCPCLOUD-2694

openshift-ci[bot] commented 3 weeks ago

Hello @jared-hayes-dev! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jared-hayes-dev Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 days ago

@jared-hayes-dev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 86d218d285880a4b70d420f8d8185d46e4fa4e96 link true /test verify
ci/prow/e2e-aws-serial 86d218d285880a4b70d420f8d8185d46e4fa4e96 link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-techpreview 86d218d285880a4b70d420f8d8185d46e4fa4e96 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial-techpreview 86d218d285880a4b70d420f8d8185d46e4fa4e96 link true /test e2e-aws-serial-techpreview
ci/prow/e2e-gcp 86d218d285880a4b70d420f8d8185d46e4fa4e96 link false /test e2e-gcp
ci/prow/e2e-aws-ovn 86d218d285880a4b70d420f8d8185d46e4fa4e96 link true /test e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn 86d218d285880a4b70d420f8d8185d46e4fa4e96 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift 86d218d285880a4b70d420f8d8185d46e4fa4e96 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-azure 86d218d285880a4b70d420f8d8185d46e4fa4e96 link false /test e2e-azure
ci/prow/e2e-upgrade 86d218d285880a4b70d420f8d8185d46e4fa4e96 link true /test e2e-upgrade
ci/prow/minor-e2e-upgrade-minor 86d218d285880a4b70d420f8d8185d46e4fa4e96 link true /test minor-e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).