search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

MON-4071: GA `MetricsCollectionProfiles` #2084

Open rexagod opened 2 weeks ago

rexagod commented 2 weeks ago

Tests: https://github.com/openshift/origin/pull/28889

Other relevant PRs:

The failures observed for test suite on all metal platforms stem from the absence of cluster-monitoring-config (CMO's configuration manifest). I'll send a patch to create one when it doesn't exists.

openshift-ci[bot] commented 2 weeks ago

Hello @rexagod! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rexagod Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 weeks ago

@rexagod: This pull request references MON-4071 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2084): >Tests: https://github.com/openshift/origin/pull/28889 > >Other relevant PRs: >* https://github.com/openshift/cluster-monitoring-operator/pull/1785 >* https://github.com/openshift/cluster-monitoring-operator/pull/2153 >* https://github.com/openshift/cluster-monitoring-operator/pull/2030 > >*** > >* [Periodic runs (Prow)](https://prow.ci.openshift.org/?job=periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview) >* [Test runs (Sippy)](https://sippy.dptools.openshift.org/sippy-ng/tests/4.18?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522current_runs%2522%252C%2522operatorValue%2522%253A%2522%253E%253D%2522%252C%2522value%2522%253A%25227%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522never-stable%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522aggregated%2522%257D%252C%257B%2522columnField%2522%253A%2522name%2522%252C%2522not%2522%253Afalse%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522%255BOCPFeatureGate%253AMetricsCollectionProfiles%255D%2522%257D%255D%252C%2522linkOperator%2522%253A%2522and%2522%257D&sort=asc&sortField=current_working_percentage) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rexagod commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2084#issuecomment-2457452678): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2084): >Tests: https://github.com/openshift/origin/pull/28889 > >Other relevant PRs: >* https://github.com/openshift/cluster-monitoring-operator/pull/1785 >* https://github.com/openshift/cluster-monitoring-operator/pull/2153 >* https://github.com/openshift/cluster-monitoring-operator/pull/2030 > >*** > >* [Periodic runs (Prow)](https://prow.ci.openshift.org/?job=pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview) >* [Test runs (Sippy)](https://sippy.dptools.openshift.org/sippy-ng/tests/4.18?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522current_runs%2522%252C%2522operatorValue%2522%253A%2522%253E%253D%2522%252C%2522value%2522%253A%25227%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522never-stable%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522aggregated%2522%257D%252C%257B%2522columnField%2522%253A%2522name%2522%252C%2522not%2522%253Afalse%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522%255BOCPFeatureGate%253AMetricsCollectionProfiles%255D%2522%257D%255D%252C%2522linkOperator%2522%253A%2522and%2522%257D&sort=asc&sortField=current_working_percentage) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rexagod commented 2 weeks ago

/test e2e-aws-serial-techpreview /test verify

openshift-merge-robot commented 2 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 weeks ago

@rexagod: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify c1b653aa009d949bbdfed0a2a74eab10cc93397e link true /test verify
ci/prow/e2e-aws-serial-techpreview c1b653aa009d949bbdfed0a2a74eab10cc93397e link true /test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 week ago

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2084): >Tests: https://github.com/openshift/origin/pull/28889 > >Other relevant PRs: >* https://github.com/openshift/cluster-monitoring-operator/pull/1785 >* https://github.com/openshift/cluster-monitoring-operator/pull/2153 >* https://github.com/openshift/cluster-monitoring-operator/pull/2030 > >*** > >* [Periodic runs (Prow: openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview)](https://prow.ci.openshift.org/?job=pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview) >* [Test runs (Sippy)](https://sippy.dptools.openshift.org/sippy-ng/tests/4.18?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522current_runs%2522%252C%2522operatorValue%2522%253A%2522%253E%253D%2522%252C%2522value%2522%253A%25227%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522never-stable%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522aggregated%2522%257D%252C%257B%2522columnField%2522%253A%2522name%2522%252C%2522not%2522%253Afalse%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522%255BOCPFeatureGate%253AMetricsCollectionProfiles%255D%2522%257D%255D%252C%2522linkOperator%2522%253A%2522and%2522%257D&sort=asc&sortField=current_working_percentage) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2084): >Tests: https://github.com/openshift/origin/pull/28889 > >Other relevant PRs: >* https://github.com/openshift/cluster-monitoring-operator/pull/1785 >* https://github.com/openshift/cluster-monitoring-operator/pull/2153 >* https://github.com/openshift/cluster-monitoring-operator/pull/2030 > >*** > >* [Periodic runs (Prow: openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview)](https://prow.ci.openshift.org/?job=pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview) >* [Test runs (Sippy)](https://sippy.dptools.openshift.org/sippy-ng/tests/4.18?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522current_runs%2522%252C%2522operatorValue%2522%253A%2522%253E%253D%2522%252C%2522value%2522%253A%25227%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522never-stable%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522aggregated%2522%257D%252C%257B%2522columnField%2522%253A%2522name%2522%252C%2522not%2522%253Afalse%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522%255BOCPFeatureGate%253AMetricsCollectionProfiles%255D%2522%257D%255D%252C%2522linkOperator%2522%253A%2522and%2522%257D&sort=asc&sortField=current_working_percentage) > >*** > >_The failures observed for test suite on all `metal` platforms stem from the absence of `cluster-monitoring-config` (CMO's configuration manifest). I'll send a patch to create one if it doesn't exist. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2084): >Tests: https://github.com/openshift/origin/pull/28889 > >Other relevant PRs: >* https://github.com/openshift/cluster-monitoring-operator/pull/1785 >* https://github.com/openshift/cluster-monitoring-operator/pull/2153 >* https://github.com/openshift/cluster-monitoring-operator/pull/2030 > >*** > >* [Periodic runs (Prow: openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview)](https://prow.ci.openshift.org/?job=pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview) >* [Test runs (Sippy)](https://sippy.dptools.openshift.org/sippy-ng/tests/4.18?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522current_runs%2522%252C%2522operatorValue%2522%253A%2522%253E%253D%2522%252C%2522value%2522%253A%25227%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522never-stable%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522aggregated%2522%257D%252C%257B%2522columnField%2522%253A%2522name%2522%252C%2522not%2522%253Afalse%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522%255BOCPFeatureGate%253AMetricsCollectionProfiles%255D%2522%257D%255D%252C%2522linkOperator%2522%253A%2522and%2522%257D&sort=asc&sortField=current_working_percentage) > >*** > >_The failures observed for test suite on all `metal` platforms stem from the absence of `cluster-monitoring-config` (CMO's configuration manifest). I'll send a patch to create one if it doesn't exist._ Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2084): >Tests: https://github.com/openshift/origin/pull/28889 > >Other relevant PRs: >* https://github.com/openshift/cluster-monitoring-operator/pull/1785 >* https://github.com/openshift/cluster-monitoring-operator/pull/2153 >* https://github.com/openshift/cluster-monitoring-operator/pull/2030 > >*** > >* [Periodic runs (Prow: openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview)](https://prow.ci.openshift.org/?job=pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview) >* [Test runs (Sippy)](https://sippy.dptools.openshift.org/sippy-ng/tests/4.18?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522current_runs%2522%252C%2522operatorValue%2522%253A%2522%253E%253D%2522%252C%2522value%2522%253A%25227%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522never-stable%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522aggregated%2522%257D%252C%257B%2522columnField%2522%253A%2522name%2522%252C%2522not%2522%253Afalse%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522%255BOCPFeatureGate%253AMetricsCollectionProfiles%255D%2522%257D%255D%252C%2522linkOperator%2522%253A%2522and%2522%257D&sort=asc&sortField=current_working_percentage) > >*** > >#### The failures observed for test suite on all `metal` platforms stem from the absence of `cluster-monitoring-config` (CMO's configuration manifest). I'll send a patch to create one if it doesn't exist. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2084): >Tests: https://github.com/openshift/origin/pull/28889 > >Other relevant PRs: >* https://github.com/openshift/cluster-monitoring-operator/pull/1785 >* https://github.com/openshift/cluster-monitoring-operator/pull/2153 >* https://github.com/openshift/cluster-monitoring-operator/pull/2030 > >*** > >* [Periodic runs (Prow: openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview)](https://prow.ci.openshift.org/?job=pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview) >* [Test runs (Sippy)](https://sippy.dptools.openshift.org/sippy-ng/tests/4.18?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522current_runs%2522%252C%2522operatorValue%2522%253A%2522%253E%253D%2522%252C%2522value%2522%253A%25227%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522never-stable%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522aggregated%2522%257D%252C%257B%2522columnField%2522%253A%2522name%2522%252C%2522not%2522%253Afalse%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522%255BOCPFeatureGate%253AMetricsCollectionProfiles%255D%2522%257D%255D%252C%2522linkOperator%2522%253A%2522and%2522%257D&sort=asc&sortField=current_working_percentage) > >*** > >#### The failures observed for test suite on all `metal` platforms stem from the absence of `cluster-monitoring-config` (CMO's configuration manifest). I'll send a patch to create one when it doesn't exists. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@rexagod: This pull request references MON-4071 which is a valid jira issue.

In response to [this](https://github.com/openshift/api/pull/2084): >Tests: https://github.com/openshift/origin/pull/28889 > >Other relevant PRs: >* https://github.com/openshift/cluster-monitoring-operator/pull/1785 >* https://github.com/openshift/cluster-monitoring-operator/pull/2153 >* https://github.com/openshift/cluster-monitoring-operator/pull/2030 > >*** > >* [Periodic runs (Prow: openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview)](https://prow.ci.openshift.org/?job=pull-ci-openshift-ovn-kubernetes-master-e2e-gcp-ovn-techpreview) >* [Test runs (Sippy)](https://sippy.dptools.openshift.org/sippy-ng/tests/4.18?filters=%257B%2522items%2522%253A%255B%257B%2522columnField%2522%253A%2522current_runs%2522%252C%2522operatorValue%2522%253A%2522%253E%253D%2522%252C%2522value%2522%253A%25227%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522never-stable%2522%257D%252C%257B%2522columnField%2522%253A%2522variants%2522%252C%2522not%2522%253Atrue%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522aggregated%2522%257D%252C%257B%2522columnField%2522%253A%2522name%2522%252C%2522not%2522%253Afalse%252C%2522operatorValue%2522%253A%2522contains%2522%252C%2522value%2522%253A%2522%255BOCPFeatureGate%253AMetricsCollectionProfiles%255D%2522%257D%255D%252C%2522linkOperator%2522%253A%2522and%2522%257D&sort=asc&sortField=current_working_percentage) > >*** > >#### The failures observed for test suite on all `metal` platforms stem from the [absence](https://github.com/openshift/origin/blob/b80ad60e2cf645636267eb9153aee23476109ec8/test/extended/prometheus/collection_profiles.go#L80) of `cluster-monitoring-config` (CMO's configuration manifest). I'll send a patch to create one when it doesn't exists. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.