search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

OCPNODE-2339: Add PKI field to (cluster)imagepolicy #2088

Open QiWang19 opened 2 weeks ago

QiWang19 commented 2 weeks ago

Add PKI to clusterimagepolicy with DevPreview featuregate SigstoreImageVerificationPKI. This field allows verification of image signature created by cosign BYOPKI feature. The enhancement: https://github.com/openshift/enhancements/commit/3b62d2f84f603e04f566236a33bccd799ba4f7ae hold this PR before https://github.com/containers/image/pull/2579

openshift-ci[bot] commented 2 weeks ago

Hello @QiWang19! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci-robot commented 2 weeks ago

@QiWang19: This pull request references OCPNODE-2339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2088): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: QiWang19 Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
QiWang19 commented 1 week ago

/test all

QiWang19 commented 1 week ago

/test verify-crd-schema

QiWang19 commented 1 week ago

/test integration

QiWang19 commented 1 week ago

/test all

QiWang19 commented 1 week ago

/test verify-crd-schema

QiWang19 commented 1 week ago

/test integration

QiWang19 commented 1 week ago

/test verify-crd-schema

QiWang19 commented 1 week ago

/test integration

QiWang19 commented 6 days ago

/test integration

QiWang19 commented 3 days ago

/test integration

QiWang19 commented 3 days ago

/test integration

QiWang19 commented 3 days ago

/test integration

QiWang19 commented 3 days ago

/test integration

QiWang19 commented 2 days ago

/hold

openshift-ci-robot commented 2 days ago

@QiWang19: This pull request references OCPNODE-2339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2088): >Add PKI to clusterimagepolicy with DevPreview featuregate SigstoreImageVerificationPKI. >This field allow verification of image signature created by cosign BYOPKI feature. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 days ago

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview b732d9f1d6ad1bd41550c078ebd176cb38e45285 link true /test e2e-aws-serial-techpreview
ci/prow/verify-crd-schema b732d9f1d6ad1bd41550c078ebd176cb38e45285 link true /test verify-crd-schema
ci/prow/e2e-gcp b732d9f1d6ad1bd41550c078ebd176cb38e45285 link false /test e2e-gcp
ci/prow/e2e-azure b732d9f1d6ad1bd41550c078ebd176cb38e45285 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 day ago

@QiWang19: This pull request references OCPNODE-2339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2088): >Add PKI to clusterimagepolicy with DevPreview featuregate SigstoreImageVerificationPKI. >This field allow verification of image signature created by cosign BYOPKI feature. >hold this PR before https://github.com/containers/image/pull/2579 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
QiWang19 commented 1 day ago

@JoelSpeed could you review?

openshift-ci-robot commented 1 day ago

@QiWang19: This pull request references OCPNODE-2339 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2088): >Add PKI to clusterimagepolicy with DevPreview featuregate SigstoreImageVerificationPKI. >This field allows verification of image signature created by cosign BYOPKI feature. >The enhancement: https://github.com/openshift/enhancements/commit/3b62d2f84f603e04f566236a33bccd799ba4f7ae >hold this PR before https://github.com/containers/image/pull/2579 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.