openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

CFE-1168: Add CMPSMachineNamePrefix feature-gate #2094

Open chiragkyal opened 1 week ago

chiragkyal commented 1 week ago

Add new CMPSMachineNamePrefix feature-gate to guard the implementation changes done to support customized control plane machine names.

openshift-ci-robot commented 1 week ago

@chiragkyal: This pull request references CFE-1168 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2094): >Add new `CMPSMachineNamePrefix` feature-gate to guard the implementation changes done to support customized control plane machine names. > >- Part of [CFE-1168](https://issues.redhat.com/browse/CFE-1168) >- Implements https://github.com/openshift/enhancements/pull/1714 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

Hello @chiragkyal! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

chiragkyal commented 1 week ago

/assign @JoelSpeed

chiragkyal commented 1 week ago

/test e2e-aws-serial-techpreview

openshift-ci[bot] commented 23 hours ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chiragkyal Once this PR has been reviewed and has the lgtm label, please ask for approval from joelspeed. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 20 hours ago

@chiragkyal: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview d20e11f92402e2cec838e53a110de0cf1f24b5fd link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn d20e11f92402e2cec838e53a110de0cf1f24b5fd link true /test e2e-aws-ovn
ci/prow/okd-scos-e2e-aws-ovn d20e11f92402e2cec838e53a110de0cf1f24b5fd link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).