Open dusk125 opened 1 week ago
@dusk125: This pull request references CNTRLPLANE-2 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
Hello @dusk125! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dusk125 Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@dusk125: This pull request references CNTRLPLANE-2 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
@dusk125: This pull request references CNTRLPLANE-2 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
@dusk125: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/minor-e2e-upgrade-minor | 00e65becb42629817e5a37aa4759b12f3fd7c29c | link | true | /test minor-e2e-upgrade-minor |
ci/prow/e2e-aws-serial-techpreview | 00e65becb42629817e5a37aa4759b12f3fd7c29c | link | true | /test e2e-aws-serial-techpreview |
ci/prow/e2e-aws-serial | 00e65becb42629817e5a37aa4759b12f3fd7c29c | link | true | /test e2e-aws-serial |
ci/prow/e2e-azure | 00e65becb42629817e5a37aa4759b12f3fd7c29c | link | false | /test e2e-azure |
ci/prow/e2e-upgrade | 00e65becb42629817e5a37aa4759b12f3fd7c29c | link | true | /test e2e-upgrade |
ci/prow/e2e-aws-ovn-techpreview | 00e65becb42629817e5a37aa4759b12f3fd7c29c | link | true | /test e2e-aws-ovn-techpreview |
ci/prow/e2e-gcp | 00e65becb42629817e5a37aa4759b12f3fd7c29c | link | false | /test e2e-gcp |
ci/prow/e2e-aws-ovn | 00e65becb42629817e5a37aa4759b12f3fd7c29c | link | true | /test e2e-aws-ovn |
ci/prow/e2e-aws-ovn-hypershift | 00e65becb42629817e5a37aa4759b12f3fd7c29c | link | true | /test e2e-aws-ovn-hypershift |
ci/prow/images | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | true | /test images |
ci/prow/verify | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | true | /test verify |
ci/prow/verify-crd-schema | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | true | /test verify-crd-schema |
ci/prow/verify-client-go | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | true | /test verify-client-go |
ci/prow/okd-scos-e2e-aws-ovn | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | false | /test okd-scos-e2e-aws-ovn |
ci/prow/minor-images | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | true | /test minor-images |
ci/prow/integration | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | true | /test integration |
ci/prow/unit | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | true | /test unit |
ci/prow/build | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | true | /test build |
ci/prow/verify-deps | 8bb054b3c24dcd2c96e6f867643ac9d73c2d6653 | link | true | /test verify-deps |
Full PR test history. Your PR dashboard.
I had to cherrypick most of Joel's changes from https://github.com/openshift/api/pull/1776 to get the api/tools updated as upstream has moved to gengo/v2.