openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

OPRUN-3401: Promote NewOLM to Default FeatureSet #2099

Closed joelanford closed 16 hours ago

joelanford commented 1 week ago

This PR promotes the NewOLM feature to the Default featureset for SelfManaged clusters. OLMv1 is not ready to be included in Hypershift clusters. The regenerated CRDs will only be pulled into the payload after this PR merges and is incorporated into https://github.com/openshift/cluster-olm-operator/pull/74

/hold

Holding until we are ready for this to merge (we have a few other tasks to execute first)

openshift-ci-robot commented 17 hours ago

/retest-required

Remaining retests: 0 against base HEAD c98acdb0b66c1ba022db2bd79b7ac40316f61a3e and 0 for PR HEAD 917f3bfd3d28f429b7e89b296acdd5906e572f92 in total

joelanford commented 17 hours ago

/override ci/prow/verify /override ci/prow/verify-crd-schema

(see https://github.com/openshift/api/pull/2099#issuecomment-2490179372)

openshift-ci[bot] commented 17 hours ago

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/verify, ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2099#issuecomment-2492103851): >/override ci/prow/verify >/override ci/prow/verify-crd-schema > >(see https://github.com/openshift/api/pull/2099#issuecomment-2490179372) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
joelanford commented 16 hours ago

/override ci/prow/verify /override ci/prow/verify-crd-schema

(see https://github.com/openshift/api/pull/2099#issuecomment-2490179372)

openshift-ci[bot] commented 16 hours ago

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/verify, ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2099#issuecomment-2492164560): >/override ci/prow/verify >/override ci/prow/verify-crd-schema > >(see https://github.com/openshift/api/pull/2099#issuecomment-2490179372) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 16 hours ago

/hold

Revision 917f3bfd3d28f429b7e89b296acdd5906e572f92 was retested 3 times: holding

joelanford commented 16 hours ago

/override ci/prow/e2e-aws-ovn-techpreview /override ci/prow/e2e-aws-ovn /override ci/prow/e2e-aws-serial-techpreview /override ci/prow/e2e-upgrade /override ci/prow/minor-e2e-upgrade-minor

These tests are unlikely to pass until a payload containing https://github.com/openshift/cluster-olm-operator/pull/74 is used as a basis. However the OLM team is concerned that https://github.com/openshift/cluster-olm-operator/pull/74, by itself may fail tests. All engineering and QE validation testing was performed on a payload that included that PR and this PR together. As such, we are proceeding with a merge here because we believe the current state (where https://github.com/openshift/cluster-olm-operator/pull/74 is merged and this PR is not is more precarious than if we force merge this one)

We will be watching builds closely and are in communication with TRT so a quick revert can happen if necessary.

joelanford commented 16 hours ago

/hold cancel

openshift-ci[bot] commented 16 hours ago

@joelanford: Overrode contexts on behalf of joelanford: ci/prow/e2e-aws-ovn, ci/prow/e2e-aws-ovn-techpreview, ci/prow/e2e-aws-serial-techpreview, ci/prow/e2e-upgrade, ci/prow/minor-e2e-upgrade-minor

In response to [this](https://github.com/openshift/api/pull/2099#issuecomment-2492284225): >/override ci/prow/e2e-aws-ovn-techpreview >/override ci/prow/e2e-aws-ovn >/override ci/prow/e2e-aws-serial-techpreview >/override ci/prow/e2e-upgrade >/override ci/prow/minor-e2e-upgrade-minor > >These tests are unlikely to pass until a payload containing https://github.com/openshift/cluster-olm-operator/pull/74 is used as a basis. However the OLM team is concerned that https://github.com/openshift/cluster-olm-operator/pull/74, by itself may fail tests. All engineering and QE validation testing was performed on a payload that included that PR and this PR together. As such, we are proceeding with a merge here because we believe the current state (where https://github.com/openshift/cluster-olm-operator/pull/74 is merged and this PR is not is more precarious than if we force merge this one) > >We will be watching builds closely and are in communication with TRT so a quick revert can happen if necessary. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 16 hours ago

@joelanford: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp 917f3bfd3d28f429b7e89b296acdd5906e572f92 link false /test e2e-gcp
ci/prow/okd-scos-e2e-aws-ovn 917f3bfd3d28f429b7e89b296acdd5906e572f92 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure 917f3bfd3d28f429b7e89b296acdd5906e572f92 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 11 hours ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.19.0-202411220011.p0.g053bb8a.assembly.stream.el9. All builds following this will include this PR.