search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

MCO-1443: Promote onclusterbuild to GA - option 2 #2100

Open yuqi-zhang opened 6 days ago

yuqi-zhang commented 6 days ago

This adds switching to v1 CRDs in the payload manifests directly, on top of the changes in https://github.com/openshift/api/pull/2090. This should work in theory since no tests are currently dependent on this, and the MCO doesn't directly use any of these objects unless both the featuregate is turned on, and the user directly opts a pool into layered builds, which at this time should only be MCO-internal tech preview tests.

openshift-ci-robot commented 6 days ago

@yuqi-zhang: This pull request references MCO-1443 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/api/pull/2100): >This adds switching to v1 CRDs in the payload manifests directly, on top of the changes in https://github.com/openshift/api/pull/2090. This should work in theory since no tests are currently dependent on this, and the MCO doesn't directly use any of these objects unless both the featuregate is turned on, and the user directly opts a pool into layered builds, which at this time should only be MCO-internal tech preview tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fapi). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 days ago

Hello @yuqi-zhang! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

openshift-ci[bot] commented 6 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yuqi-zhang Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 6 days ago

@yuqi-zhang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-hypershift a6b3eb5a3e6eef41752cc45c5dec8370fee732e4 link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-gcp a6b3eb5a3e6eef41752cc45c5dec8370fee732e4 link false /test e2e-gcp
ci/prow/e2e-aws-ovn-techpreview a6b3eb5a3e6eef41752cc45c5dec8370fee732e4 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial-techpreview a6b3eb5a3e6eef41752cc45c5dec8370fee732e4 link true /test e2e-aws-serial-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).