Open bertinatto opened 3 days ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: bertinatto Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@bertinatto: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/build | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | true | /test build |
ci/prow/verify-crd-schema | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | true | /test verify-crd-schema |
ci/prow/verify | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | true | /test verify |
ci/prow/unit | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | true | /test unit |
ci/prow/minor-images | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | true | /test minor-images |
ci/prow/images | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | true | /test images |
ci/prow/verify-deps | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | true | /test verify-deps |
ci/prow/integration | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | true | /test integration |
ci/prow/verify-client-go | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | true | /test verify-client-go |
ci/prow/okd-scos-e2e-aws-ovn | 4423434d67cf3bd5ad77c12b2e5416920d42f5d5 | link | false | /test okd-scos-e2e-aws-ovn |
Full PR test history. Your PR dashboard.
PR needs rebase.
Hello @bertinatto! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.