search

openshift / api

Canonical location of the OpenShift API definition.
http://www.openshift.org
Apache License 2.0
94 stars 517 forks source link

OCPBUGS-44324 : Rename files to use the default run-level for storage #2105

Closed bertinatto closed 15 hours ago

bertinatto commented 2 days ago

This ensures that CRD updates are applied earlier during a cluster upgrade process. This prevents CSI operators from accessing new/updated fields of the CR before the corresponding CRDs been updated.

CC @openshift/storage

openshift-ci[bot] commented 2 days ago

Hello @bertinatto! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

deads2k commented 2 days ago

You may re-number as you wish, but I think the default is 80, so moving 50 to 80 is probably bad.

deads2k commented 2 days ago

/lgtm /approve

wking commented 2 days ago

...but I think the default is 80...

The default is 50 (code and docs).

openshift-ci[bot] commented 1 day ago

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 15f57180903f8c9728d0a57eb0296d6b8b4545b5 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
JoelSpeed commented 1 day ago

Looks better now, schema checker error is not fixable

/lgtm /override ci/prow/verify-crd-schema-checker

Does this need the ack critical fixes label?

openshift-ci[bot] commented 1 day ago

@JoelSpeed: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/api/pull/2105#issuecomment-2489780948): >Looks better now, schema checker error is not fixable > >/lgtm >/override ci/prow/verify-crd-schema-checker > >Does this need the ack critical fixes label? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 day ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, deads2k, JoelSpeed, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)~~ [JoelSpeed,deads2k] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bertinatto commented 18 hours ago

Looks better now, schema checker error is not fixable

/lgtm /override ci/prow/verify-crd-schema-checker

Does this need the ack critical fixes label?

Adding the label, as this can fix an issue that has been blocking the Storage team:

/label acknowledge-critical-fixes-only

JoelSpeed commented 17 hours ago

/override ci/prow/verify-crd-schema

openshift-ci[bot] commented 17 hours ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema

In response to [this](https://github.com/openshift/api/pull/2105#issuecomment-2490974254): >/override ci/prow/verify-crd-schema Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 17 hours ago

/retest-required

Remaining retests: 0 against base HEAD caf97963ed302881f01e67b791ae4efc6bcf723c and 2 for PR HEAD 15f57180903f8c9728d0a57eb0296d6b8b4545b5 in total

gnufied commented 17 hours ago

This indeed appears to fix the issue. I made a build from this PR and upgraded from 4.17 and operator logs appeared to be calm.

openshift-bot commented 12 hours ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api This PR has been included in build ose-cluster-config-api-container-v4.19.0-202411211638.p0.gec9bf3f.assembly.stream.el9. All builds following this will include this PR.