Allow multiple FeatureGates in integration test config

[swghosh]

Using a comma separated string containing multiple feature gates in a single string in SuiteSpec (integration test config).

[openshift-ci[bot]]

Hello @swghosh! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swghosh Once this PR has been reviewed and has the lgtm label, please assign spadgett for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[JoelSpeed]

@swghosh how hard do you think it would be to rewrite the format of the suitespec across this repo? Could a regex find/replace help here?

[swghosh]

@JoelSpeed PTAL

[JoelSpeed]

I think this looks ok generally, but, any idea why it thinks the controlplanemachineset without MachineAPIMigration file now has no CRD to match with?

And, do we have anything we can use to demonstrate that this achieves what we want? Allowing combinations of gates for tests?

[chiragkyal]

I think this looks ok generally, but, any idea why it thinks the controlplanemachineset without MachineAPIMigration file now has no CRD to match with?

And, do we have anything we can use to demonstrate that this achieves what we want? Allowing combinations of gates for tests?

https://github.com/openshift/api/pull/2086/commits/77b2eb581ec428278e131914a6c2b32898cff158 can fix the issue and demonstrate that it works as expected.

https://github.com/openshift/api/pull/2086

[chiragkyal]

https://github.com/openshift/api/commit/77b2eb581ec428278e131914a6c2b32898cff158 can fix the issue and demonstrate that it works as expected.

After adding some more tests into https://github.com/openshift/api/pull/2086, it looks like now controlplanemachinesets-Default.crd.yaml is complaining. :(

The crd_filter logic might need some more fix.

[swghosh]

77b2eb5 can fix the issue and demonstrate that it works as expected.

After adding some more tests into #2086, it looks like now controlplanemachinesets-Default.crd.yaml is complaining. :(

The crd_filter logic might need some more fix.

@chiragkyal Flipped the bool, fixed the filter (the previous ones were all incorrect, needed an AND instead of OR).

It will make your test pass with your machine/v1/tests/controlplanemachinesets.machine.openshift.io/CMPSMachineNamePrefix.yaml.

[openshift-ci[bot]]

@swghosh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	c6a467f361c3bf4d08d8727980e0b79e7a7a2b5c	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).