openshift / assisted-installer-agent

Apache License 2.0
24 stars 77 forks source link

MGMT-17869: Agent changes for F5 DNS load balancer #712

Closed ori-amizur closed 4 months ago

ori-amizur commented 4 months ago

Add CNAME to domain resolution results if it CNAME resolution exists for the domain

/cc @gamli75 /cc @zaneb

openshift-ci-robot commented 4 months ago

@ori-amizur: This pull request references MGMT-17869 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/712): >Add CNAME to domain resolution results if it CNAME resolution exists for the domain > >/cc @gamli75 >/cc @zaneb Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 59.91%. Comparing base (569f4e4) to head (39668c5).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/712/graphs/tree.svg?width=650&height=150&src=pr&token=ZYXZPU4167&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/712?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #712 +/- ## ========================================== - Coverage 59.99% 59.91% -0.08% ========================================== Files 74 74 Lines 3692 3705 +13 ========================================== + Hits 2215 2220 +5 - Misses 1320 1328 +8 Partials 157 157 ``` | [Files](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/712?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [src/domain\_resolution/domain\_resolution.go](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/712?src=pr&el=tree&filepath=src%2Fdomain_resolution%2Fdomain_resolution.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-c3JjL2RvbWFpbl9yZXNvbHV0aW9uL2RvbWFpbl9yZXNvbHV0aW9uLmdv) | `57.40% <33.33%> (-10.89%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/712/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-installer-agent/blob/master/OWNERS)~~ [ori-amizur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ori-amizur commented 4 months ago

/retest-required

openshift-ci[bot] commented 4 months ago

@ori-amizur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tsorya commented 4 months ago

/lgtm

openshift-bot commented 4 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-node-agent-container-v4.17.0-202405271013.p0.gab42a45.assembly.stream.el9 for distgit ose-agent-installer-node-agent. All builds following this will include this PR.