openshift / assisted-installer-agent

Apache License 2.0
24 stars 74 forks source link

MGMT-17353: Debug pod left in ImagePullBackOff after install in disconnected environment #719

Closed ori-amizur closed 1 month ago

ori-amizur commented 1 month ago

Pass the flag to the installer indicating if num reboots event should be generated. The flag is called "notify-num-reboots".

openshift-ci-robot commented 1 month ago

@ori-amizur: This pull request references MGMT-17353 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/719): >Pass the flag to the installer indicating if num reboots event should be generated. The flag is called "notify-num-reboots". Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

ori-amizur commented 1 month ago

/cc @gamli75

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.86%. Comparing base (a13a4ce) to head (f2efbcd).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/719/graphs/tree.svg?width=650&height=150&src=pr&token=ZYXZPU4167&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/719?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #719 +/- ## ========================================== - Coverage 59.89% 59.86% -0.04% ========================================== Files 74 74 Lines 3703 3705 +2 ========================================== Hits 2218 2218 - Misses 1328 1329 +1 - Partials 157 158 +1 ``` | [Files](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/719?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [src/commands/actions/install\_cmd.go](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/719?src=pr&el=tree&filepath=src%2Fcommands%2Factions%2Finstall_cmd.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-c3JjL2NvbW1hbmRzL2FjdGlvbnMvaW5zdGFsbF9jbWQuZ28=) | `75.14% <100.00%> (+0.29%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/719/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
openshift-ci[bot] commented 1 month ago

@ori-amizur: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, ori-amizur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-installer-agent/blob/master/OWNERS)~~ [gamli75,ori-amizur] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-node-agent-container-v4.17.0-202406031213.p0.gd63fd09.assembly.stream.el9 for distgit ose-agent-installer-node-agent. All builds following this will include this PR.

ori-amizur commented 1 week ago

/cherry-pick release-ocm-2.10

openshift-cherrypick-robot commented 1 week ago

@ori-amizur: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error messagestatus code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#list-pull-requests-files","status":"406"}
In response to [this](https://github.com/openshift/assisted-installer-agent/pull/719#issuecomment-2214446062): >/cherry-pick release-ocm-2.10 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.