search

openshift / assisted-installer-agent

Apache License 2.0
24 stars 77 forks source link

MGMT-17560: Report iSCSI host IP address in inventory #727

Closed adriengentil closed 2 months ago

adriengentil commented 3 months ago

Report iSCSI host IP address in the inventory, it will be used to perform validations on service side when the iSCSI disk is selected as installation disk:

PRs part of this story:

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 3 months ago

@adriengentil: This pull request references MGMT-17560 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/727): >- **vendor models from wip** >- **[MGMT-17560](https://issues.redhat.com//browse/MGMT-17560): Report iSCSI host IP address in inventory** > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@adriengentil: This pull request references MGMT-17560 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/727): >Report iSCSI host IP address in the inventory, it will be used to >perform validations on service side when the iSCSI disk is selected as >installation disk: >- Check that host IP is not part of the default network interface >- Ensure machine network does not contain the iSCSI host IP address >- Configure network on the iSCSI network interface Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-installer-agent/blob/master/OWNERS)~~ [adriengentil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@adriengentil: This pull request references MGMT-17560 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/727): >Report iSCSI host IP address in the inventory, it will be used to >perform validations on service side when the iSCSI disk is selected as >installation disk: >- Check that host IP is not part of the default network interface >- Ensure machine network does not contain the iSCSI host IP address >- Configure network on the iSCSI network interface > >depends on: https://github.com/openshift/assisted-service/pull/6434 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@adriengentil: This pull request references MGMT-17560 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/727): >Report iSCSI host IP address in the inventory, it will be used to >perform validations on service side when the iSCSI disk is selected as >installation disk: >- Check that host IP is not part of the default network interface >- Ensure machine network does not contain the iSCSI host IP address > >depends on: https://github.com/openshift/assisted-service/pull/6434 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@adriengentil: This pull request references MGMT-17560 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/727): >Report iSCSI host IP address in the inventory, it will be used to >perform validations on service side when the iSCSI disk is selected as >installation disk: >- Check that host IP is not part of the default network interface >- Ensure machine network does not contain the iSCSI host IP address > >PRs part of this story: >- Validate iSCSI volume eligibility on hosts: https://github.com/openshift/assisted-service/pull/6434 >- Report iSCSI host ip address: https://github.com/openshift/assisted-installer-agent/pull/727 >- Configure DHCP on iSCSI network interface: https://github.com/openshift/assisted-service/pull/6602 >- Workaround DNS issue on first boot: https://github.com/openshift/assisted-service/pull/6603 >- Filter out machine networks: TODO Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
adriengentil commented 2 months ago

/cc @ori-amizur @linoyaslan

adriengentil commented 2 months ago

/hold requires https://github.com/openshift/assisted-service/pull/6434 to be merged before, in order to update the API/models

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 9 lines in your changes missing coverage. Please review.

Project coverage is 59.95%. Comparing base (84bf92d) to head (40a2f70).

Files Patch % Lines
src/inventory/disks.go 57.14% 6 Missing and 3 partials :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/727/graphs/tree.svg?width=650&height=150&src=pr&token=ZYXZPU4167&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/727?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #727 +/- ## ========================================== + Coverage 59.91% 59.95% +0.03% ========================================== Files 74 74 Lines 3710 3731 +21 ========================================== + Hits 2223 2237 +14 - Misses 1329 1334 +5 - Partials 158 160 +2 ``` | [Files](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/727?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [src/inventory/disks.go](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/727?src=pr&el=tree&filepath=src%2Finventory%2Fdisks.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-c3JjL2ludmVudG9yeS9kaXNrcy5nbw==) | `88.35% <57.14%> (-2.09%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/727/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
adriengentil commented 2 months ago

/unhold

eifrach commented 2 months ago

known issue

/override edge-subsystem-test

openshift-ci[bot] commented 2 months ago

@eifrach: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/727#issuecomment-2271796622): >know issue > >/override edge-subsystem-test > > > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
eifrach commented 2 months ago

/override ci/prow/edge-subsystem-test

openshift-ci[bot] commented 2 months ago

@eifrach: Overrode contexts on behalf of eifrach: ci/prow/edge-subsystem-test

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/727#issuecomment-2271798028): >/override ci/prow/edge-subsystem-test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
eifrach commented 2 months ago

/lgtm

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-node-agent This PR has been included in build ose-agent-installer-node-agent-container-v4.17.0-202408061814.p0.ge1f67db.assembly.stream.el9. All builds following this will include this PR.