openshift / assisted-installer-agent

Apache License 2.0
24 stars 74 forks source link

NO-ISSUE: Align build dockerfile to use go-toolset for go & centos9 for dep #745

Closed pastequo closed 6 days ago

pastequo commented 2 weeks ago

Second round of CI adjustment https://github.com/openshift/assisted-installer-agent/pull/735

This time, trying to align our build dockerfile on the same logic across our repo

/cc @danmanor

openshift-ci-robot commented 2 weeks ago

@pastequo: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/745): >Second round of CI adjustment https://github.com/openshift/assisted-installer-agent/pull/735 > >This time, trying to align our build dockerfile on the same logic across our repo > >/cc @danmanor Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pastequo Once this PR has been reviewed and has the lgtm label, please assign eliorerz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/assisted-installer-agent/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.97%. Comparing base (3963f20) to head (143b49a). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/745/graphs/tree.svg?width=650&height=150&src=pr&token=ZYXZPU4167&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #745 +/- ## ========================================== + Coverage 59.91% 59.97% +0.05% ========================================== Files 74 74 Lines 3710 3710 ========================================== + Hits 2223 2225 +2 + Misses 1329 1328 -1 + Partials 158 157 -1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/745/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
openshift-ci[bot] commented 2 weeks ago

@pastequo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
pastequo commented 2 weeks ago

/hold

pastequo commented 2 weeks ago

/unhold

openshift-merge-robot commented 1 week ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.