openshift / assisted-installer-agent

Apache License 2.0
24 stars 74 forks source link

[release-ocm-2.11] MGMT-18332: Use centos stream 9 as the base image for test container #749

Closed danmanor closed 1 week ago

danmanor commented 1 week ago
openshift-ci-robot commented 1 week ago

@danmanor: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/749): >- Use centos stream 9 as the base image for test container >- Replace deprecated scopelint linter Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-installer-agent/blob/release-ocm-2.11/OWNERS)~~ [danmanor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.86%. Comparing base (dfe67f1) to head (c35d269).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/749/graphs/tree.svg?width=650&height=150&src=pr&token=ZYXZPU4167&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/749?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-ocm-2.11 #749 +/- ## ==================================================== - Coverage 59.91% 59.86% -0.06% ==================================================== Files 74 74 Lines 3705 3705 ==================================================== - Hits 2220 2218 -2 - Misses 1328 1329 +1 - Partials 157 158 +1 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/749/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
danmanor commented 1 week ago

/override ci/prow/e2e-ai-operator-ztp

openshift-ci[bot] commented 1 week ago

@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-ai-operator-ztp

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/749#issuecomment-2212465308): >/override ci/prow/e2e-ai-operator-ztp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 week ago

@danmanor: This pull request references MGMT-18336 which is a valid jira issue.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/749): >- Use centos stream 9 as the base image for test container >- Replace deprecated scopelint linter Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 week ago

@danmanor: This pull request references MGMT-18332 which is a valid jira issue.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/749): >- Use centos stream 9 as the base image for test container >- Replace deprecated scopelint linter Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 week ago

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rccrdpccl commented 1 week ago

/lgtm /approve

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, rccrdpccl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-installer-agent/blob/release-ocm-2.11/OWNERS)~~ [danmanor,rccrdpccl] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment