openshift / assisted-installer-agent

Apache License 2.0
24 stars 81 forks source link

MGMT-19166: Implement MTU checker #821

Open linoyaslan opened 1 week ago

linoyaslan commented 1 week ago

As part of the MTU validation implementation, the agent will include the MTU checker in the connectivity check. It will send reports to the service if a ping with the specified MTU size fails.

openshift-ci-robot commented 1 week ago

@linoyaslan: This pull request references MGMT-19166 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/821): >As part of the MTU validation implementation, the agent will include the MTU checker in the connectivity check. It will send reports to the service if a ping with the specified MTU size fails. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer-agent). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 64.81481% with 19 lines in your changes missing coverage. Please review.

Project coverage is 60.21%. Comparing base (a0b1057) to head (f2cb3b5). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/connectivity_check/mtu_checker.go 64.70% 14 Missing and 4 partials :warning:
src/connectivity_check/connectivity_check.go 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/821/graphs/tree.svg?width=650&height=150&src=pr&token=ZYXZPU4167&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/821?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #821 +/- ## ========================================== + Coverage 60.16% 60.21% +0.05% ========================================== Files 74 75 +1 Lines 3891 3944 +53 ========================================== + Hits 2341 2375 +34 - Misses 1384 1399 +15 - Partials 166 170 +4 ``` | [Files with missing lines](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/821?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [src/connectivity\_check/connectivity\_runner.go](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/821?src=pr&el=tree&filepath=src%2Fconnectivity_check%2Fconnectivity_runner.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-c3JjL2Nvbm5lY3Rpdml0eV9jaGVjay9jb25uZWN0aXZpdHlfcnVubmVyLmdv) | `92.30% <ø> (ø)` | | | [src/connectivity\_check/util.go](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/821?src=pr&el=tree&filepath=src%2Fconnectivity_check%2Futil.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-c3JjL2Nvbm5lY3Rpdml0eV9jaGVjay91dGlsLmdv) | `74.64% <100.00%> (+0.36%)` | :arrow_up: | | [src/connectivity\_check/connectivity\_check.go](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/821?src=pr&el=tree&filepath=src%2Fconnectivity_check%2Fconnectivity_check.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-c3JjL2Nvbm5lY3Rpdml0eV9jaGVjay9jb25uZWN0aXZpdHlfY2hlY2suZ28=) | `0.00% <0.00%> (ø)` | | | [src/connectivity\_check/mtu\_checker.go](https://app.codecov.io/gh/openshift/assisted-installer-agent/pull/821?src=pr&el=tree&filepath=src%2Fconnectivity_check%2Fmtu_checker.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-c3JjL2Nvbm5lY3Rpdml0eV9jaGVjay9tdHVfY2hlY2tlci5nbw==) | `64.70% <64.70%> (ø)` | |

🚨 Try these New Features:

linoyaslan commented 6 days ago

/hold

linoyaslan commented 5 days ago

/override ci/prow/e2e-agent-compact-ipv4

openshift-ci[bot] commented 5 days ago

@linoyaslan: linoyaslan unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/821#issuecomment-2491281027): >/override ci/prow/e2e-agent-compact-ipv4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 5 days ago

@linoyaslan: linoyaslan unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/821#issuecomment-2491244314): >/override ci/prow/e2e-agent-compact-ipv4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
eifrach commented 5 days ago

/override ci/prow/e2e-agent-compact-ipv4

eifrach commented 5 days ago

/lgtm

openshift-ci[bot] commented 5 days ago

@eifrach: Overrode contexts on behalf of eifrach: ci/prow/e2e-agent-compact-ipv4

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/821#issuecomment-2491365200): >/override ci/prow/e2e-agent-compact-ipv4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 5 days ago

New changes are detected. LGTM label has been removed.

openshift-ci[bot] commented 5 days ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: linoyaslan Once this PR has been reviewed and has the lgtm label, please ask for approval from eifrach. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/assisted-installer-agent/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
linoyaslan commented 2 days ago

/override ci/prow/e2e-agent-compact-ipv4

openshift-ci[bot] commented 2 days ago

@linoyaslan: Overrode contexts on behalf of linoyaslan: ci/prow/e2e-agent-compact-ipv4

In response to [this](https://github.com/openshift/assisted-installer-agent/pull/821#issuecomment-2495916986): >/override ci/prow/e2e-agent-compact-ipv4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 days ago

@linoyaslan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).