Closed eifrach closed 2 months ago
@eifrach: all tests passed!
Full PR test history. Your PR dashboard.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: danmanor, eifrach
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/remove-label downstream-change-needed
/retitle MGMT-18550: bump golang 1.21
@eifrach: This pull request references MGMT-18550 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.
[ART PR BUILD NOTIFIER]
Distgit: ose-agent-installer-csr-approver This PR has been included in build ose-agent-installer-csr-approver-container-v4.18.0-202408121342.p0.g4635ddf.assembly.stream.el9. All builds following this will include this PR.
[ART PR BUILD NOTIFIER]
Distgit: ose-agent-installer-orchestrator This PR has been included in build ose-agent-installer-orchestrator-container-v4.18.0-202408121342.p0.g4635ddf.assembly.stream.el9. All builds following this will include this PR.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Additional details and impacted files
[![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-installer/pull/894/graphs/tree.svg?width=650&height=150&src=pr&token=X6PHZZFE9E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-installer/pull/894?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #894 +/- ## ======================================= Coverage 55.70% 55.70% ======================================= Files 15 15 Lines 3208 3208 ======================================= Hits 1787 1787 Misses 1249 1249 Partials 172 172 ```