search

openshift / assisted-installer

Apache License 2.0
69 stars 98 forks source link

ACM-14587: Switch to github.com/docker/distribution/reference to mitigate CVE-2024-3727 #908

Closed paul-maidment closed 1 month ago

paul-maidment commented 1 month ago

The library github.com/containers/image/v5 has a vulnerability that has as of yet been unresolved.

Thankfully, it is possible to change the part of the library that we use

We can change github.com/containers/image/v5/docker/reference for github.com/docker/distribution/reference

openshift-ci-robot commented 1 month ago

@paul-maidment: This pull request references Jira Issue OCPBUGS-42332, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/assisted-installer/pull/908): >The library github.com/containers/image/v5 has a vulnerability that has as of yet been unresolved. > >Thankfully, it is possible to change the part of the library that we use > >We can change github.com/containers/image/v5/docker/reference for github.com/docker/distribution/reference Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 55.70%. Comparing base (1914567) to head (1203e05). Report is 1 commits behind head on release-ocm-2.11.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-installer/pull/908/graphs/tree.svg?width=650&height=150&src=pr&token=X6PHZZFE9E&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-installer/pull/908?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-ocm-2.11 #908 +/- ## ================================================= Coverage 55.70% 55.70% ================================================= Files 15 15 Lines 3208 3208 ================================================= Hits 1787 1787 Misses 1249 1249 Partials 172 172 ``` | [Flag](https://app.codecov.io/gh/openshift/assisted-installer/pull/908/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/openshift/assisted-installer/pull/908/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | `55.70% <ø> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#carryforward-flags-in-the-pull-request-comment) to find out more.
openshift-ci[bot] commented 1 month ago

@paul-maidment: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, paul-maidment

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-installer/blob/release-ocm-2.11/OWNERS)~~ [gamli75] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
paul-maidment commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@paul-maidment: This pull request references Jira Issue OCPBUGS-42332, which is valid. The bug has been moved to the POST state.

5 validation(s) were run on this bug * bug is open, matching expected state (open) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-42312](https://issues.redhat.com//browse/OCPBUGS-42312) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * bug has dependents

Requesting review from QA contact: /cc @mhanss

In response to [this](https://github.com/openshift/assisted-installer/pull/908#issuecomment-2381252683): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@paul-maidment: Jira Issue OCPBUGS-42332: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42332 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/assisted-installer/pull/908): >The library github.com/containers/image/v5 has a vulnerability that has as of yet been unresolved. > >Thankfully, it is possible to change the part of the library that we use > >We can change github.com/containers/image/v5/docker/reference for github.com/docker/distribution/reference Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.