search

openshift / assisted-installer

Apache License 2.0
69 stars 98 forks source link

[release-4.17] OCPBUGS-42839: Allow controller to continue when assisted-service #918

Closed openshift-cherrypick-robot closed 2 weeks ago

openshift-cherrypick-robot commented 3 weeks ago

This is an automated cherry-pick of #896

/assign rwsu

openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-38466 has been cloned as Jira Issue OCPBUGS-42839. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-42839: Allow controller to continue when assisted-service

In response to [this](https://github.com/openshift/assisted-installer/pull/918): >This is an automated cherry-pick of #896 > >/assign rwsu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-42839, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/assisted-installer/pull/918): >This is an automated cherry-pick of #896 > >/assign rwsu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rwsu commented 3 weeks ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 weeks ago

@rwsu: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/assisted-installer/pull/918#issuecomment-2397992074): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rwsu commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@rwsu: This pull request references Jira Issue OCPBUGS-42839, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/assisted-installer/pull/918#issuecomment-2397993693): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rwsu commented 3 weeks ago

/assign @gamli75 @zaneb @mhanss

rwsu commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gamli75, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-installer/blob/release-4.17/OWNERS)~~ [gamli75] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
zaneb commented 3 weeks ago

/label backport-risk-assessed

mhanss commented 3 weeks ago

/label cherry-pick-approved

rwsu commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@rwsu: This pull request references Jira Issue OCPBUGS-42839, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.z) matches configured target version for branch (4.17.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-38466](https://issues.redhat.com//browse/OCPBUGS-38466) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-38466](https://issues.redhat.com//browse/OCPBUGS-38466) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @mhanss

In response to [this](https://github.com/openshift/assisted-installer/pull/918#issuecomment-2413987474): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 weeks ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-42839: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42839 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/assisted-installer/pull/918): >This is an automated cherry-pick of #896 > >/assign rwsu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-installer). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 weeks ago

@rwsu: new pull request created: #934

In response to [this](https://github.com/openshift/assisted-installer/pull/918#issuecomment-2397992074): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-orchestrator This PR has been included in build ose-agent-installer-orchestrator-container-v4.17.0-202410151905.p0.g9614e8b.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-csr-approver This PR has been included in build ose-agent-installer-csr-approver-container-v4.17.0-202410151905.p0.g9614e8b.assembly.stream.el9. All builds following this will include this PR.