search

openshift / assisted-service

Apache License 2.0
109 stars 209 forks source link

[release-ocm-2.11] MGMT-18313: Replace golang base image as it is based on Centos Linux 7 #6647

Closed danmanor closed 1 month ago

danmanor commented 1 month ago

Backport of https://github.com/openshift/assisted-service/pull/6637

openshift-ci-robot commented 1 month ago

@danmanor: This pull request references MGMT-18313 which is a valid jira issue.

In response to [this](https://github.com/openshift/assisted-service/pull/6647): >Backport of https://github.com/openshift/assisted-service/pull/6637 > > > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [ ] Bug fix >- [ ] Tests >- [ ] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > > > >- [ ] assisted-test-infra environment >- [ ] dev-scripts environment >- [ ] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [ ] Manual (Elaborate on how it was tested) >- [x] No tests needed > >## Checklist > >- [ ] Title and description added to both, commit and PR. >- [ ] Relevant issues have been associated (see [CONTRIBUTING] guide) >- [ ] This change does not require a documentation update (docstring, `docs`, README, etc) >- [ ] Does this change include unit-tests (note that code changes require unit-tests) > >## Reviewers Checklist > >- Are the title and description (in both PR and commit) meaningful and clear? >- Is there a bug required (and linked) for this change? >- Should this PR be backported? > >[Kubernetes community documentation]: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines >[CONTRIBUTING]: https://github.com/openshift/assisted-service/blob/master/CONTRIBUTING.md > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/release-ocm-2.11/OWNERS)~~ [danmanor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@danmanor: This pull request references MGMT-18313 which is a valid jira issue.

In response to [this](https://github.com/openshift/assisted-service/pull/6647): >Backport of https://github.com/openshift/assisted-service/pull/6637 > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.50%. Comparing base (9509d78) to head (2a75a13). Report is 1 commits behind head on release-ocm-2.11.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-service/pull/6647/graphs/tree.svg?width=650&height=150&src=pr&token=YOR4NSSOXQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-service/pull/6647?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-ocm-2.11 #6647 +/- ## ================================================= Coverage 68.50% 68.50% ================================================= Files 247 247 Lines 36334 36334 ================================================= Hits 24889 24889 Misses 9242 9242 Partials 2203 2203 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6647/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
danmanor commented 1 month ago

/hold

danmanor commented 1 month ago

/unhold

danmanor commented 1 month ago

/cc @adriengentil @eifrach

danmanor commented 1 month ago

/retest

eifrach commented 1 month ago

/lgtm

danmanor commented 1 month ago

/retest

danmanor commented 1 month ago

/test images

danmanor commented 1 month ago

/retest

eifrach commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).