openshift / assisted-service

Apache License 2.0
109 stars 209 forks source link

NO-ISSUE: Print subsystem environment variables before test #6654

Closed eliorerz closed 1 month ago

eliorerz commented 1 month ago

When we started using kind we stopped printing the test environment variables before running the test, this PR adds those back.

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

/cc @eliorerz

openshift-ci-robot commented 1 month ago

@eliorerz: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/assisted-service/pull/6654): > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [ ] Bug fix >- [x] Tests >- [ ] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > > > >- [ ] assisted-test-infra environment >- [ ] dev-scripts environment >- [ ] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [x] Manual (Elaborate on how it was tested) >- [ ] No tests needed > >/cc @eliorerz Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

@eliorerz: GitHub didn't allow me to request PR reviews from the following users: eliorerz.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/openshift/assisted-service/pull/6654): > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [ ] Bug fix >- [x] Tests >- [ ] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > > > >- [ ] assisted-test-infra environment >- [ ] dev-scripts environment >- [ ] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [x] Manual (Elaborate on how it was tested) >- [ ] No tests needed > >/cc @eliorerz Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.66%. Comparing base (9964f08) to head (19d52ca). Report is 20 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-service/pull/6654/graphs/tree.svg?width=650&height=150&src=pr&token=YOR4NSSOXQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-service/pull/6654?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #6654 +/- ## ========================================== + Coverage 68.55% 68.66% +0.10% ========================================== Files 246 246 Lines 36673 37215 +542 ========================================== + Hits 25141 25553 +412 - Misses 9292 9414 +122 - Partials 2240 2248 +8 ``` [see 11 files with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6654/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/master/OWNERS)~~ [danmanor,eliorerz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
eliorerz commented 1 month ago

/override ci/prow/edge-e2e-ai-operator-ztp

openshift-ci[bot] commented 1 month ago

@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/edge-e2e-ai-operator-ztp

In response to [this](https://github.com/openshift/assisted-service/pull/6654#issuecomment-2271198011): >/override ci/prow/edge-e2e-ai-operator-ztp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server This PR has been included in build ose-agent-installer-api-server-container-v4.18.0-202408061615.p0.g0420cf9.assembly.stream.el9. All builds following this will include this PR.