search

openshift / assisted-service

Apache License 2.0
109 stars 209 forks source link

NO-ISSUE: Add missing kube api flag on kube api subsystem test #6655

Closed eliorerz closed 1 month ago

eliorerz commented 1 month ago

Fix subsystem kubeapi tests when ENABLE_KUBE_API is not exported. As described in https://github.com/openshift/assisted-service/blob/master/docs/dev/running-test.md#running-the-tests - exporting ENABLE_KUBE_API should be transparent to whom running the tests

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

/cc @danmanor

openshift-ci-robot commented 1 month ago

@eliorerz: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/assisted-service/pull/6655): >Fix subsystem kubeapi tests when `ENABLE_KUBE_API` is not exported. >As described in https://github.com/openshift/assisted-service/blob/master/docs/dev/running-test.md#running-the-tests - exporting `ENABLE_KUBE_API` should be transparent to whom running the tests > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [ ] Bug fix >- [x] Tests >- [ ] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > > > >- [ ] assisted-test-infra environment >- [ ] dev-scripts environment >- [ ] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [ ] Manual (Elaborate on how it was tested) >- [x] No tests needed > >/cc @danmanor Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.67%. Comparing base (a969ac4) to head (ad9a074). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-service/pull/6655/graphs/tree.svg?width=650&height=150&src=pr&token=YOR4NSSOXQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-service/pull/6655?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #6655 +/- ## ========================================== + Coverage 68.55% 68.67% +0.12% ========================================== Files 246 246 Lines 36691 37215 +524 ========================================== + Hits 25152 25557 +405 - Misses 9299 9412 +113 - Partials 2240 2246 +6 ``` [see 8 files with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6655/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/master/OWNERS)~~ [danmanor,eliorerz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
eliorerz commented 1 month ago

/override ci/prow/edge-e2e-ai-operator-ztp

openshift-ci[bot] commented 1 month ago

@eliorerz: Overrode contexts on behalf of eliorerz: ci/prow/edge-e2e-ai-operator-ztp

In response to [this](https://github.com/openshift/assisted-service/pull/6655#issuecomment-2271198737): >/override ci/prow/edge-e2e-ai-operator-ztp Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 0420cf9651ea41ac1c2e7bece9767f7b6dadc9ae and 2 for PR HEAD ad9a074fbbdce265450fa0cdbb8edc3d3da26d1c in total

openshift-ci[bot] commented 1 month ago

@eliorerz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server This PR has been included in build ose-agent-installer-api-server-container-v4.17.0-202408062045.p0.g6dd2882.assembly.stream.el9. All builds following this will include this PR.