search

openshift / assisted-service

Apache License 2.0
109 stars 209 forks source link

[release-ocm-2.9] MGMT-18313: Replace golang base image as it is based on Centos Linux 7 #6656

Closed danmanor closed 1 month ago

danmanor commented 1 month ago

Backport of https://github.com/openshift/assisted-service/pull/6637

openshift-ci-robot commented 1 month ago

@danmanor: This pull request references MGMT-18313 which is a valid jira issue.

In response to [this](https://github.com/openshift/assisted-service/pull/6656): >Backport of https://github.com/openshift/assisted-service/pull/6637 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/release-ocm-2.9/OWNERS)~~ [danmanor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
danmanor commented 1 month ago

/cc @eifrach

danmanor commented 1 month ago

/cc @adriengentil

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 67.67%. Comparing base (de606fd) to head (a922cf3).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-service/pull/6656/graphs/tree.svg?width=650&height=150&src=pr&token=YOR4NSSOXQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-service/pull/6656?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-ocm-2.9 #6656 +/- ## =================================================== - Coverage 67.68% 67.67% -0.01% =================================================== Files 232 232 Lines 34119 34119 =================================================== - Hits 23093 23090 -3 - Misses 8979 8980 +1 - Partials 2047 2049 +2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6656/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
danmanor commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
eifrach commented 1 month ago

/lgtm