openshift / assisted-service

Apache License 2.0
109 stars 209 forks source link

NO-ISSUE: Fix debug image by adding required packages #6659

Closed danmanor closed 1 month ago

danmanor commented 1 month ago

Leftover from - https://github.com/openshift/assisted-service/pull/6637

openshift-ci-robot commented 1 month ago

@danmanor: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/assisted-service/pull/6659): >Leftover from - https://github.com/openshift/assisted-service/pull/6637 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.63%. Comparing base (6dd2882) to head (535dd07). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-service/pull/6659/graphs/tree.svg?width=650&height=150&src=pr&token=YOR4NSSOXQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-service/pull/6659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #6659 +/- ## ========================================== + Coverage 68.53% 68.63% +0.10% ========================================== Files 246 246 Lines 36740 36857 +117 ========================================== + Hits 25179 25298 +119 + Misses 9318 9316 -2 Partials 2243 2243 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6659/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
danmanor commented 1 month ago

/retest

danmanor commented 1 month ago

/test edge-unit-test

eifrach commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/master/OWNERS)~~ [adriengentil,danmanor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD d79f85c0968397e449e9944c4ee9be7616d4e864 and 2 for PR HEAD 535dd07b245e44c1fee3783621ba5da239e2ed62 in total

openshift-ci[bot] commented 1 month ago

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server This PR has been included in build ose-agent-installer-api-server-container-v4.18.0-202408072043.p0.g1f7cce3.assembly.stream.el9. All builds following this will include this PR.