NO-ISSUE: Support both minikube and kind for deploying on k8s cluster

danmanor commented 1 month ago

Support both minikube and kind for deploying on k8s cluster

List all the issues related to this PR

[ ] New Feature
[ ] Enhancement
[ ] Bug fix
[ ] Tests
[ ] Documentation
[x] CI/CD

What environments does this code impact?

[ ] Automation (CI, tools, etc)
[ ] Cloud
[ ] Operator Managed Deployments
[x] None

How was this code tested?

[ ] assisted-test-infra environment
[ ] dev-scripts environment
[ ] Reviewer's test appreciated
[x] Waiting for CI to do a full test run
[ ] Manual (Elaborate on how it was tested)
[ ] No tests needed

Checklist

[x] Title and description added to both, commit and PR.
[x] Relevant issues have been associated (see CONTRIBUTING guide)
[x] This change does not require a documentation update (docstring, docs, README, etc)
[ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

openshift-ci-robot commented 1 month ago

@danmanor: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/assisted-service/pull/6664): > > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [ ] Bug fix >- [ ] Tests >- [ ] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > > > >- [ ] assisted-test-infra environment >- [ ] dev-scripts environment >- [ ] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [ ] Manual (Elaborate on how it was tested) >- [x] No tests needed > >## Checklist > >- [ ] Title and description added to both, commit and PR. >- [ ] Relevant issues have been associated (see [CONTRIBUTING] guide) >- [ ] This change does not require a documentation update (docstring, `docs`, README, etc) >- [ ] Does this change include unit-tests (note that code changes require unit-tests) > >## Reviewers Checklist > >- Are the title and description (in both PR and commit) meaningful and clear? >- Is there a bug required (and linked) for this change? >- Should this PR be backported? > >[Kubernetes community documentation]: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines >[CONTRIBUTING]: https://github.com/openshift/assisted-service/blob/master/CONTRIBUTING.md > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/master/OWNERS)~~ [danmanor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.63%. Comparing base (d3324b0) to head (690397f). Report is 2 commits behind head on master.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-service/pull/6664/graphs/tree.svg?width=650&height=150&src=pr&token=YOR4NSSOXQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-service/pull/6664?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #6664 +/- ## ======================================= Coverage 68.63% 68.63% ======================================= Files 246 246 Lines 36860 36860 ======================================= Hits 25300 25300 Misses 9307 9307 Partials 2253 2253 ``` [see 2 files with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6664/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)

danmanor commented 4 weeks ago

/cc @eifrach @eliorerz