MGMT-18384: bump golang 1.21

eifrach commented 1 month ago

List all the issues related to this PR

[ ] New Feature
[ ] Enhancement
[ ] Bug fix
[ ] Tests
[ ] Documentation
[ ] CI/CD

What environments does this code impact?

[ ] Automation (CI, tools, etc)
[ ] Cloud
[ ] Operator Managed Deployments
[x] None

How was this code tested?

[ ] assisted-test-infra environment
[ ] dev-scripts environment
[ ] Reviewer's test appreciated
[ ] Waiting for CI to do a full test run
[ ] Manual (Elaborate on how it was tested)
[x] No tests needed

Checklist

[ ] Title and description added to both, commit and PR.
[ ] Relevant issues have been associated (see CONTRIBUTING guide)
[ ] This change does not require a documentation update (docstring, docs, README, etc)
[ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/master/OWNERS)~~ [eifrach] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

adriengentil commented 1 month ago

Why not bumping to 1.22? Since master follows 4.17, dependencies we rely on may require go 1.22, see https://github.com/openshift/assisted-service/pull/6641

eifrach commented 1 month ago

Why not bumping to 1.22? Since master follows 4.17, dependencies we rely on may require go 1.22, see #6641

There isn't any official Ubi / RHEL images for 1.22 yet

eifrach commented 4 weeks ago

/retest-required

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.06%. Comparing base (f40fe42) to head (2c3097c). Report is 10 commits behind head on master.

Additional details and impacted files

[![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-service/pull/6667/graphs/tree.svg?width=650&height=150&src=pr&token=YOR4NSSOXQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-service/pull/6667?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #6667 +/- ## ========================================== + Coverage 68.56% 69.06% +0.49% ========================================== Files 246 246 Lines 36820 37275 +455 ========================================== + Hits 25246 25743 +497 + Misses 9326 9285 -41 + Partials 2248 2247 -1 ``` [see 14 files with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6667/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)

danmanor commented 3 weeks ago

/lgtm

eifrach commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@eifrach: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/assisted-service/pull/6667#issuecomment-2295201306): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci-robot commented 3 weeks ago

@eifrach: This pull request references MGMT-18384 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-service/pull/6667): > > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [ ] Bug fix >- [ ] Tests >- [ ] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > > > >- [ ] assisted-test-infra environment >- [ ] dev-scripts environment >- [ ] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [ ] Manual (Elaborate on how it was tested) >- [x] No tests needed > >## Checklist > >- [ ] Title and description added to both, commit and PR. >- [ ] Relevant issues have been associated (see [CONTRIBUTING] guide) >- [ ] This change does not require a documentation update (docstring, `docs`, README, etc) >- [ ] Does this change include unit-tests (note that code changes require unit-tests) > >## Reviewers Checklist > >- Are the title and description (in both PR and commit) meaningful and clear? >- Is there a bug required (and linked) for this change? >- Should this PR be backported? > >[Kubernetes community documentation]: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines >[CONTRIBUTING]: https://github.com/openshift/assisted-service/blob/master/CONTRIBUTING.md > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

eifrach commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@eifrach: This pull request references MGMT-18384 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-service/pull/6667#issuecomment-2295203919): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 3 weeks ago

@eifrach: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-agent-installer-api-server This PR has been included in build ose-agent-installer-api-server-container-v4.18.0-202408181611.p0.gd3324b0.assembly.stream.el9. All builds following this will include this PR.

openshift / assisted-service