search

openshift / assisted-service

Apache License 2.0
109 stars 209 forks source link

OCPBUGS-41716: Fix MCO reboot error for s390x #6682

Closed AmadeusPodvratnik closed 2 weeks ago

AmadeusPodvratnik commented 4 weeks ago

Problem: For s390x architectures a multiarch payload is blocked and choosing a multi image via Assisted Installer or Agend-based Installer shows the error: "cannot use Skip MCO reboot because it's not compatible with the s390x architecture..." This check is obsolete because s390x is supporting mutlitarch payloads. Solution: With this fix the feature will be enabled for s390x architectures. Test: The switch was removed for s390x architecture and the existing tests where adapted. Test was done using assisted-test-infra by using the branch. Doc: There is a misleading information in the Doc and should be removed but this is not related to this PR because e.g. for ppc64le architecture the statement is wrong, too (Bug). Nevertheless the doc for Assisted Installer need to be verified and adapted.

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented 4 weeks ago

@AmadeusPodvratnik: This pull request references MGMT-17805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-service/pull/6682): >Problem: For s390x architectures a multiarch payload is blocked and choosing a multi image via Assisted Installer or Agend-based Installer shows the error: "cannot use Skip MCO reboot because it's not compatible with the s390x architecture..." >This check is obsolete because s390x is supporting mutlitarch payloads. >Solution: With this fix the feature will be enabled for s390x architectures. >Test: The switch was removed for s390x architecture and the existing tests where adapted. >Doc: There is a misleading information in the Doc and should be removed but this is not related to this PR because e.g. for ppc64le architecture the statement is wrong, too (Bug). Nevertheless the doc for Assisted Installer need to be verified and adapted. > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [x] Bug fix >- [ ] Tests >- [x] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > >- [ ] assisted-test-infra environment >- [x] dev-scripts environment >- [x] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [ ] Manual (Elaborate on how it was tested) >- [ ] No tests needed > >## Checklist > >- [x] Title and description added to both, commit and PR. >- [x] Relevant issues have been associated (see [CONTRIBUTING] guide) >- [ ] This change does not require a documentation update (docstring, `docs`, README, etc) >- [x] Does this change include unit-tests (note that code changes require unit-tests) > >## Reviewers Checklist > >- Are the title and description (in both PR and commit) meaningful and clear? >- Is there a bug required (and linked) for this change? >- Should this PR be backported? > >[Kubernetes community documentation]: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines >[CONTRIBUTING]: https://github.com/openshift/assisted-service/blob/master/CONTRIBUTING.md > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 weeks ago

Hi @AmadeusPodvratnik. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 weeks ago

@AmadeusPodvratnik: This pull request references MGMT-17805 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-service/pull/6682): >Problem: For s390x architectures a multiarch payload is blocked and choosing a multi image via Assisted Installer or Agend-based Installer shows the error: "cannot use Skip MCO reboot because it's not compatible with the s390x architecture..." >This check is obsolete because s390x is supporting mutlitarch payloads. >Solution: With this fix the feature will be enabled for s390x architectures. >Test: The switch was removed for s390x architecture and the existing tests where adapted. Test was done using assisted-test-infra by using the branch. >Doc: There is a misleading information in the Doc and should be removed but this is not related to this PR because e.g. for ppc64le architecture the statement is wrong, too (Bug). Nevertheless the doc for Assisted Installer need to be verified and adapted. > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [x] Bug fix >- [ ] Tests >- [x] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > >- [ ] assisted-test-infra environment >- [x] dev-scripts environment >- [x] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [ ] Manual (Elaborate on how it was tested) >- [ ] No tests needed > >## Checklist > >- [x] Title and description added to both, commit and PR. >- [x] Relevant issues have been associated (see [CONTRIBUTING] guide) >- [ ] This change does not require a documentation update (docstring, `docs`, README, etc) >- [x] Does this change include unit-tests (note that code changes require unit-tests) > >## Reviewers Checklist > >- Are the title and description (in both PR and commit) meaningful and clear? >- Is there a bug required (and linked) for this change? >- Should this PR be backported? > >[Kubernetes community documentation]: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines >[CONTRIBUTING]: https://github.com/openshift/assisted-service/blob/master/CONTRIBUTING.md > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
AmadeusPodvratnik commented 2 weeks ago

@eliorerz I run tests to verify the fix using assisted-test-infra.

eliorerz commented 2 weeks ago

/ok-to-test

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.63%. Comparing base (00a5eb3) to head (b30fc8b). Report is 18 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-service/pull/6682/graphs/tree.svg?width=650&height=150&src=pr&token=YOR4NSSOXQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-service/pull/6682?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #6682 +/- ## ========================================== + Coverage 68.60% 68.63% +0.03% ========================================== Files 246 246 Lines 36796 36859 +63 ========================================== + Hits 25243 25299 +56 - Misses 9304 9307 +3 - Partials 2249 2253 +4 ``` | [Files with missing lines](https://app.codecov.io/gh/openshift/assisted-service/pull/6682?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [internal/featuresupport/features\_misc.go](https://app.codecov.io/gh/openshift/assisted-service/pull/6682?src=pr&el=tree&filepath=internal%2Ffeaturesupport%2Ffeatures_misc.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-aW50ZXJuYWwvZmVhdHVyZXN1cHBvcnQvZmVhdHVyZXNfbWlzYy5nbw==) | `88.51% <100.00%> (-1.42%)` | :arrow_down: | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6682/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
eliorerz commented 2 weeks ago

/test ?

openshift-ci[bot] commented 2 weeks ago

@eliorerz: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/assisted-service/pull/6682#issuecomment-2317293412): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AmadeusPodvratnik, eliorerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/master/OWNERS)~~ [eliorerz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
AmadeusPodvratnik commented 1 week ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 week ago

@AmadeusPodvratnik: only openshift org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to [this](https://github.com/openshift/assisted-service/pull/6682#issuecomment-2326069091): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
apodvrat commented 1 week ago

/cherry-pick release-4.17

openshift-cherrypick-robot commented 1 week ago

@apodvrat: new pull request created: #6727

In response to [this](https://github.com/openshift/assisted-service/pull/6682#issuecomment-2330736987): >/cherry-pick release-4.17 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
carbonin commented 1 week ago

IIUC the 4.17 branch is only used by the agent-based-installer. Was your intention to include it there with this cherry-pick?

cc @zaneb @rwsu

AmadeusPodvratnik commented 1 week ago

@carbonin I talked with @zaneb about this and yes, the bug should be backported to release-4.17 to be available in OCP 4.17.

carbonin commented 6 days ago

Okay, just making sure.

openshift-ci-robot commented 2 days ago

@AmadeusPodvratnik: Jira Issue OCPBUGS-41716: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-41716 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/assisted-service/pull/6682): >Problem: For s390x architectures a multiarch payload is blocked and choosing a multi image via Assisted Installer or Agend-based Installer shows the error: "cannot use Skip MCO reboot because it's not compatible with the s390x architecture..." >This check is obsolete because s390x is supporting mutlitarch payloads. >Solution: With this fix the feature will be enabled for s390x architectures. >Test: The switch was removed for s390x architecture and the existing tests where adapted. Test was done using assisted-test-infra by using the branch. >Doc: There is a misleading information in the Doc and should be removed but this is not related to this PR because e.g. for ppc64le architecture the statement is wrong, too (Bug). Nevertheless the doc for Assisted Installer need to be verified and adapted. > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [x] Bug fix >- [ ] Tests >- [x] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > >- [ ] assisted-test-infra environment >- [x] dev-scripts environment >- [x] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [ ] Manual (Elaborate on how it was tested) >- [ ] No tests needed > >## Checklist > >- [x] Title and description added to both, commit and PR. >- [x] Relevant issues have been associated (see [CONTRIBUTING] guide) >- [ ] This change does not require a documentation update (docstring, `docs`, README, etc) >- [x] Does this change include unit-tests (note that code changes require unit-tests) > >## Reviewers Checklist > >- Are the title and description (in both PR and commit) meaningful and clear? >- Is there a bug required (and linked) for this change? >- Should this PR be backported? > >[Kubernetes community documentation]: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines >[CONTRIBUTING]: https://github.com/openshift/assisted-service/blob/master/CONTRIBUTING.md > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.