MGMT-18589: Enhancement doc for backup/restore support

danielerez commented 4 weeks ago

Enhancement document for improving the backup/restore support.

List all the issues related to this PR

[ ] New Feature
[ ] Enhancement
[ ] Bug fix
[ ] Tests
[x] Documentation
[ ] CI/CD

What environments does this code impact?

[ ] Automation (CI, tools, etc)
[ ] Cloud
[ ] Operator Managed Deployments
[x] None

How was this code tested?

[ ] assisted-test-infra environment
[ ] dev-scripts environment
[ ] Reviewer's test appreciated
[ ] Waiting for CI to do a full test run
[ ] Manual (Elaborate on how it was tested)
[x] No tests needed

Checklist

[x] Title and description added to both, commit and PR.
[x] Relevant issues have been associated (see CONTRIBUTING guide)
[ ] This change does not require a documentation update (docstring, docs, README, etc)
[ ] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

openshift-ci-robot commented 4 weeks ago

@danielerez: This pull request references MGMT-18589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-service/pull/6683): >Enhancement document for improving the backup/restore support. > > > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [ ] Bug fix >- [ ] Tests >- [x] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [ ] Operator Managed Deployments >- [x] None > >## How was this code tested? > > > >- [ ] assisted-test-infra environment >- [ ] dev-scripts environment >- [ ] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [ ] Manual (Elaborate on how it was tested) >- [x] No tests needed > >## Checklist > >- [x] Title and description added to both, commit and PR. >- [x] Relevant issues have been associated (see [CONTRIBUTING] guide) >- [ ] This change does not require a documentation update (docstring, `docs`, README, etc) >- [ ] Does this change include unit-tests (note that code changes require unit-tests) > >## Reviewers Checklist > >- Are the title and description (in both PR and commit) meaningful and clear? >- Is there a bug required (and linked) for this change? >- Should this PR be backported? > >[Kubernetes community documentation]: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines >[CONTRIBUTING]: https://github.com/openshift/assisted-service/blob/master/CONTRIBUTING.md > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 4 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

danielerez commented 4 weeks ago

/cc @carbonin /cc @avishayt /cc @CrystalChun /cc @jhernand /cc @gamli75 /cc @oourfali

carbonin commented 2 weeks ago

This is looking better.

@avishayt is there anything here you can resolve or clear up?

Also how many of the open questions and remaining discussions do we want to fully settle before merging. I imagine some of these will only be resolved with some spike/dev work.

avishayt commented 2 weeks ago

I agree with @carbonin . Looks good enough to proceed.

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avishayt, danielerez

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/master/OWNERS)~~ [avishayt,danielerez] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

danielerez commented 2 weeks ago

/retest

openshift-ci[bot] commented 2 weeks ago

@danielerez: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift / assisted-service