search

openshift / assisted-service

Apache License 2.0
109 stars 209 forks source link

[release-ocm-2.10] MGMT-18623: Add 4.16 OS images for ACM 2.10 #6684

Closed mihirlele closed 3 weeks ago

mihirlele commented 4 weeks ago

List all the issues related to this PR

What environments does this code impact?

How was this code tested?

Checklist

Reviewers Checklist

openshift-ci-robot commented 4 weeks ago

@mihirlele: This pull request references MGMT-18623 which is a valid jira issue.

In response to [this](https://github.com/openshift/assisted-service/pull/6684): > > >## List all the issues related to this PR > >- [ ] New Feature >- [ ] Enhancement >- [✓] Bug fix >- [ ] Tests >- [ ] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [✓] Operator Managed Deployments >- [x] None > >## How was this code tested? > > > >- [ ] assisted-test-infra environment >- [ ] dev-scripts environment >- [ ] Reviewer's test appreciated >- [✓] Waiting for CI to do a full test run >- [ ] Manual (Elaborate on how it was tested) >- [x] No tests needed > >## Checklist > >- [✓] Title and description added to both, commit and PR. >- [✓] Relevant issues have been associated (see [CONTRIBUTING] guide) >- [✓] This change does not require a documentation update (docstring, `docs`, README, etc) >- [ ] Does this change include unit-tests (note that code changes require unit-tests) > >## Reviewers Checklist > >- Are the title and description (in both PR and commit) meaningful and clear? >- Is there a bug required (and linked) for this change? >- Should this PR be backported? > >[Kubernetes community documentation]: https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#commit-message-guidelines >[CONTRIBUTING]: https://github.com/openshift/assisted-service/blob/master/CONTRIBUTING.md > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 weeks ago

Hi @mihirlele. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
danmanor commented 3 weeks ago

/ok-to-test

danmanor commented 3 weeks ago

/retitle [release-ocm-2.10] MGMT-18623: Add 4.16 OS images for ACM 2.10

danmanor commented 3 weeks ago

/lgtm

danmanor commented 3 weeks ago

/test

openshift-ci[bot] commented 3 weeks ago

@danmanor: The /test command needs one or more targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/assisted-service/pull/6684#issuecomment-2295255416): >/test Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.31%. Comparing base (aa36091) to head (7bd122b).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/assisted-service/pull/6684/graphs/tree.svg?width=650&height=150&src=pr&token=YOR4NSSOXQ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/assisted-service/pull/6684?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-ocm-2.10 #6684 +/- ## ==================================================== + Coverage 68.30% 68.31% +0.01% ==================================================== Files 236 236 Lines 35096 35096 ==================================================== + Hits 23972 23976 +4 + Misses 9050 9048 -2 + Partials 2074 2072 -2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6684/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD aa36091b939ce8233bbd67f93231b737c4a9380b and 2 for PR HEAD 7bd122b4d6a74130663a8fcad018ef6fcd9a74c4 in total

danmanor commented 3 weeks ago

/approve

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor, mihirlele

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/release-ocm-2.10/OWNERS)~~ [danmanor] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
danmanor commented 3 weeks ago

/override Red Hat Konflux

openshift-ci[bot] commented 3 weeks ago

@danmanor: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/assisted-service/pull/6684#issuecomment-2295842695): >/override Red Hat Konflux Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
danmanor commented 3 weeks ago

/override "Red Hat Konflux"

openshift-ci[bot] commented 3 weeks ago

@danmanor: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/assisted-service/pull/6684#issuecomment-2295843697): >/override "Red Hat Konflux" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
danmanor commented 3 weeks ago

/override "Red Hat Konflux / Red Hat Konflux"

openshift-ci[bot] commented 3 weeks ago

@danmanor: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/assisted-service/pull/6684#issuecomment-2295880375): >/override "Red Hat Konflux / Red Hat Konflux" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
danmanor commented 3 weeks ago

/override Red Hat Konflux / Red Hat Konflux

openshift-ci[bot] commented 3 weeks ago

@danmanor: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/assisted-service/pull/6684#issuecomment-2295928564): >/override Red Hat Konflux / Red Hat Konflux Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
danmanor commented 3 weeks ago

/ok-to-test

danmanor commented 3 weeks ago

/retest

openshift-ci[bot] commented 3 weeks ago

@mihirlele: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
danmanor commented 3 weeks ago

/close

danmanor commented 3 weeks ago

replaced by - https://github.com/openshift/assisted-service/pull/6688

openshift-ci[bot] commented 3 weeks ago

@danmanor: Closed this PR.

In response to [this](https://github.com/openshift/assisted-service/pull/6684#issuecomment-2296417692): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.