MGMT-18418: Reapply "Add certs to ingress when deploying in non-OCP clusters (#6564)"

[carbonin]

This reverts commit 9964f0870d5df042a782bb9c6394835d05ad807a.

The re-adds the ingress certs now that the CAPI provider is using the internal service IP for the BMH.

List all the issues related to this PR

Resolves https://issues.redhat.com/browse/MGMT-18418 Requires https://github.com/openshift-assisted/cluster-api-agent/pull/51 (merged)

• [ ] New Feature
• [ ] Enhancement
• [x] Bug fix
• [ ] Tests
• [ ] Documentation
• [ ] CI/CD

What environments does this code impact?

• [ ] Automation (CI, tools, etc)
• [ ] Cloud
• [x] Operator Managed Deployments
• [ ] None

How was this code tested?

Tested manually in a Sylva test environment with the updated CAPI provider. Saw that a SNO was installed successfully.

• [ ] assisted-test-infra environment
• [ ] dev-scripts environment
• [ ] Reviewer's test appreciated
• [ ] Waiting for CI to do a full test run
• [x] Manual (Elaborate on how it was tested)
• [ ] No tests needed

Checklist

• [x] Title and description added to both, commit and PR.
• [x] Relevant issues have been associated (see [CONTRIBUTING] guide)
• [x] This change does not require a documentation update (docstring, docs, README, etc)
• [x] Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

• Are the title and description (in both PR and commit) meaningful and clear?
• Is there a bug required (and linked) for this change?
• Should this PR be backported?

[openshift-ci-robot]

@carbonin: This pull request references MGMT-18418 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/openshift/assisted-service/pull/6685): >This reverts commit 9964f0870d5df042a782bb9c6394835d05ad807a. > >The re-adds the ingress certs now that the CAPI provider is using the internal service IP for the BMH. > >## List all the issues related to this PR > >Resolves https://issues.redhat.com/browse/MGMT-18418 >Requires https://github.com/openshift-assisted/cluster-api-agent/pull/51 (merged) > >- [ ] New Feature >- [ ] Enhancement >- [x] Bug fix >- [ ] Tests >- [ ] Documentation >- [ ] CI/CD > >## What environments does this code impact? > >- [ ] Automation (CI, tools, etc) >- [ ] Cloud >- [x] Operator Managed Deployments >- [ ] None > >## How was this code tested? > >Tested manually in a Sylva test environment with the updated CAPI provider. >Saw that a SNO was installed successfully. > > > >- [ ] assisted-test-infra environment >- [ ] dev-scripts environment >- [ ] Reviewer's test appreciated >- [ ] Waiting for CI to do a full test run >- [x] Manual (Elaborate on how it was tested) >- [ ] No tests needed > >## Checklist > >- [x] Title and description added to both, commit and PR. >- [x] Relevant issues have been associated (see [CONTRIBUTING] guide) >- [x] This change does not require a documentation update (docstring, `docs`, README, etc) >- [x] Does this change include unit-tests (note that code changes require unit-tests) > >## Reviewers Checklist > >- Are the title and description (in both PR and commit) meaningful and clear? >- Is there a bug required (and linked) for this change? >- Should this PR be backported? > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fassisted-service). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carbonin, CrystalChun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/assisted-service/blob/master/OWNERS)~~ [CrystalChun,carbonin] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.19%. Comparing base (61c279a) to head (70fc2e7). Report is 2 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/openshift/assisted-service/pull/6685?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #6685 +/- ## ========================================== + Coverage 68.62% 69.19% +0.57% ========================================== Files 246 246 Lines 36836 37524 +688 ========================================== + Hits 25277 25963 +686 + Misses 9307 9301 -6 - Partials 2252 2260 +8 ``` | [Files](https://app.codecov.io/gh/openshift/assisted-service/pull/6685?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [...oller/controllers/agentserviceconfig\_controller.go](https://app.codecov.io/gh/openshift/assisted-service/pull/6685?src=pr&el=tree&filepath=internal%2Fcontroller%2Fcontrollers%2Fagentserviceconfig_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-aW50ZXJuYWwvY29udHJvbGxlci9jb250cm9sbGVycy9hZ2VudHNlcnZpY2Vjb25maWdfY29udHJvbGxlci5nbw==) | `84.19% <100.00%> (+0.09%)` | :arrow_up: | | [internal/controller/controllers/kube\_compat.go](https://app.codecov.io/gh/openshift/assisted-service/pull/6685?src=pr&el=tree&filepath=internal%2Fcontroller%2Fcontrollers%2Fkube_compat.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-aW50ZXJuYWwvY29udHJvbGxlci9jb250cm9sbGVycy9rdWJlX2NvbXBhdC5nbw==) | `90.24% <100.00%> (+0.58%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/openshift/assisted-service/pull/6685/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)

[openshift-ci[bot]]

@carbonin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).