vkareh commented 3 years ago

To allow for better separation of API versus business logic, we move the apis to be its own module within the operator code. This allows external projects to import just the API as necessary without pulling in potentially-conflicting dependencies.

Also remove api dependency on controller-runtime to allow OCM to import the necessary APIs.

Please see https://issues.redhat.com/browse/OSD-6948

codecov-io commented 3 years ago

Codecov Report

Merging #545 (38c11e2) into master (7b7d7ff) will increase coverage by 0.15%. The diff coverage is 63.63%.

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   14.10%   14.25%   +0.15%     
==========================================
  Files          44       45       +1     
  Lines        3601     3612      +11     
==========================================
+ Hits          508      515       +7     
- Misses       3071     3075       +4     
  Partials       22       22

Impacted Files	Coverage Δ
apis/addtoscheme_aws_v1alpha1.go	`100.00% <ø> (ø)`
apis/apis.go	`100.00% <ø> (ø)`
apis/aws/v1alpha1/account_types.go	`90.47% <ø> (ø)`
apis/aws/v1alpha1/accountclaim_types.go	`100.00% <ø> (ø)`
apis/aws/v1alpha1/accountpool_types.go	`100.00% <ø> (ø)`
...is/aws/v1alpha1/awsfederatedaccountaccess_types.go	`100.00% <ø> (ø)`
apis/aws/v1alpha1/awsfederatedrole_types.go	`100.00% <ø> (ø)`
apis/aws/v1alpha1/register.go	`0.00% <ø> (ø)`
cmd/manager/main.go	`0.00% <ø> (ø)`
pkg/awsclient/iam.go	`0.00% <ø> (ø)`
... and 23 more

iamkirkbater commented 3 years ago

Integration tests all ran fine locally.

jharrington22 commented 3 years ago

/lgtm

@rogbas @iamkirkbater I'll leave it to you to approve.

jharrington22 commented 3 years ago

/hold

iamkirkbater commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamkirkbater, jharrington22, vkareh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater,jharrington22] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

iamkirkbater commented 3 years ago

/hold cancel

openshift / aws-account-operator

apis: Move to separate module #545

Codecov Report