openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

apis: Move back to pkg/apis #554

Closed vkareh closed 3 years ago

vkareh commented 3 years ago

Since the operator-sdk expects types to be in the pkg/apis directory, we move them back and ensure that there is a go.mod file to allow importing this directory individually.

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vkareh To complete the pull request process, please assign rogbas after the PR has been reviewed. You can assign the PR to them by writing /assign @rogbas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 years ago

@vkareh: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/validate 869f34c691e9a5d3a38cbcff2013d4c029c88c72 link /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 3 years ago

@vkareh: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
drpaneas commented 3 years ago

Fixed in https://github.com/openshift/aws-account-operator/pull/580/files