Fix make generate - Githubissues

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive

Apache License 2.0

32 stars 75 forks source link

Fix make generate #557

Closed drpaneas closed 3 years ago

drpaneas commented 3 years ago

Introduces go.tools which can be used as a placeholder to put go get-able stuff that are required for the project, such as the openapi-gen. As such the go.mod gets tricked and uses those as indirect dependencies.
Introduces make download that runs go mod download to fetch the golang universe.
Introduces make install-tools which is running go install $tool against all the lines at tools.go and has make download as a prereq.
Removes lint and isclean as they are undefined in the makefile - obsoleted.

PS: I am not including golangci-lint as this is handled by the boilerplate code.

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: drpaneas To complete the pull request process, please assign iamkirkbater after the PR has been reviewed. You can assign the PR to them by writing /assign @iamkirkbater in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 3 years ago

@drpaneas: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/validate	cc4cc77e6d612b4a1cad53c6b8ae505f4cef9c48	link	`/test validate`
ci/prow/test	cc4cc77e6d612b4a1cad53c6b8ae505f4cef9c48	link	`/test test`
ci/prow/lint	cc4cc77e6d612b4a1cad53c6b8ae505f4cef9c48	link	`/test lint`
ci/prow/images	cc4cc77e6d612b4a1cad53c6b8ae505f4cef9c48	link	`/test images`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

2uasimojo commented 3 years ago

Introduces go.tools which can be used as a placeholder to put go get-able stuff that are required for the project, such as the openapi-gen. As such the go.mod gets tricked and uses those as indirect dependencies.

You shouldn't need to do this for generate/build/test/lint related deps The boilerplate backing image already contains openapi-gen and other necessaries. Trying to install and run that stuff locally might work, but eventually will cause you headaches due to platform and version discrepancies. Instead run those things through container-make, which uses said backing image, which contains said tools.

Removes lint and isclean as they are undefined in the makefile - obsoleted.

lint and isclean are defined in the boilerplate standard.mk.

drpaneas commented 3 years ago

I wasn't aware of this container. So, it seems we have everything. Please adjust the documentation to include this information.

2uasimojo commented 3 years ago

Please adjust the documentation to include this information.

The main README references the boilerplate convention's README, which mentions container-make. If you have a suggestion for making it more obvious, I'm all :ear:s