search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

update openshift template #565

Closed maorfr closed 3 years ago

maorfr commented 3 years ago

related to https://issues.redhat.com/browse/APPSRE-3265

Right now, you should define REPO_DIGEST in the OpenShift template, and it should be enough. Nothing else needed in the OpenShift template itself. In the SaaS file, you need to define REGISTRY_IMG, to be able to generate REPO_DIGEST. You don't need to define REGISTRY_IMG in the OpenShift template. IMAGE_TAG is always generated, and you don't need to define in the SaaS file or in the OpenShift template.

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maorfr To complete the pull request process, please assign iamkirkbater after the PR has been reviewed. You can assign the PR to them by writing /assign @iamkirkbater in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
2uasimojo commented 3 years ago

Superseded by #577