search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Adds necessary field for Support ARN #567

Closed iamkirkbater closed 3 years ago

iamkirkbater commented 3 years ago

Reverts openshift/aws-account-operator#566

Adds back in the supportRoleARN fields now that the change freeze is (almost) lifted.

Originally was PR #564. Satisfies the same OSD requirements.

iamkirkbater commented 3 years ago

/hold

Still has a dependency on app-interface.

iamkirkbater commented 3 years ago

/hold cancel

App interface PR has merged. This should be ready to move forward.

dastergon commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment