openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

[OSD-7116] Adding validation to Secretref Name and Namespace #568

Closed dkeohane closed 3 years ago

dkeohane commented 3 years ago

Fix for OSD-7116

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dkeohane To complete the pull request process, please assign rogbas after the PR has been reviewed. You can assign the PR to them by writing /assign @rogbas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 3 years ago

Codecov Report

Merging #568 (d44daf4) into master (e01ae9d) will increase coverage by 0.29%. The diff coverage is 2.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
+ Coverage   13.46%   13.76%   +0.29%     
==========================================
  Files          44       44              
  Lines        3774     3808      +34     
==========================================
+ Hits          508      524      +16     
- Misses       3243     3261      +18     
  Partials       23       23              
Impacted Files Coverage Δ
pkg/controller/account/account_controller.go 0.36% <0.00%> (-0.03%) :arrow_down:
pkg/controller/account/byoc.go 34.81% <0.00%> (-0.13%) :arrow_down:
pkg/controller/account/iam.go 0.00% <0.00%> (ø)
...controller/accountclaim/accountclaim_controller.go 8.20% <0.00%> (+0.45%) :arrow_up:
...kg/controller/accountclaim/organizational_units.go 16.19% <0.00%> (ø)
pkg/controller/accountclaim/reuse.go 25.68% <0.00%> (-0.09%) :arrow_down:
...er/awsfederatedrole/awsfederatedrole_controller.go 0.00% <0.00%> (ø)
pkg/controller/utils/conditions.go 0.00% <ø> (ø)
pkg/controller/utils/status.go 0.00% <0.00%> (ø)
pkg/controller/utils/utils.go 41.30% <ø> (ø)
... and 3 more
iamkirkbater commented 3 years ago

/label tide/merge-method-squash

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkeohane, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dkeohane commented 3 years ago

/hold cancel