search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Fix namespace in UHC ClusterRoleBinding #569

Closed NautiluX closed 3 years ago

NautiluX commented 3 years ago
dastergon commented 3 years ago

/lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dastergon, NautiluX To complete the pull request process, please assign rogbas after the PR has been reviewed. You can assign the PR to them by writing /assign @rogbas in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
2uasimojo commented 3 years ago

/lgtm

lisa commented 3 years ago

/assign @iamkirkbater

lisa commented 3 years ago

/approve /lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dastergon, lisa, NautiluX

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [lisa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 3 years ago

Codecov Report

Merging #569 (3d0a5c6) into master (b26c233) will increase coverage by 0.75%. The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   13.76%   14.52%   +0.75%     
==========================================
  Files          45       45              
  Lines        3741     4325     +584     
==========================================
+ Hits          515      628     +113     
- Misses       3203     3673     +470     
- Partials       23       24       +1
Impacted Files Coverage Δ
cmd/manager/main.go 0.00% <ø> (ø)
pkg/apis/addtoscheme_aws_v1alpha1.go 100.00% <ø> (ø)
pkg/apis/apis.go 100.00% <ø> (ø)
pkg/apis/aws/v1alpha1/account_types.go 89.70% <ø> (ø)
pkg/apis/aws/v1alpha1/accountpool_types.go 100.00% <ø> (ø)
...is/aws/v1alpha1/awsfederatedaccountaccess_types.go 100.00% <ø> (ø)
pkg/apis/aws/v1alpha1/awsfederatedrole_types.go 100.00% <ø> (ø)
pkg/apis/aws/v1alpha1/register.go 0.00% <ø> (ø)
pkg/awsclient/client.go 0.00% <ø> (ø)
pkg/awsclient/iam.go 0.00% <ø> (ø)
... and 66 more