search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Boilerplate: Update to 0ba6566d544d0df9993a92b2286c131eb61f3e88 #573

Closed 2uasimojo closed 3 years ago

2uasimojo commented 3 years ago

Conventions:

commit: 7679eeabd8af9bcd1deb2ef998d862e275fdb3f2 author: Eric Fried Split out stderr for skopeo inspect

This started happening suddenly:

10:08:43 parse error: Invalid literal at line 1, column 6
10:08:43 Unexpected error: skopeo inspect succeeded, but output contained no .Digest
10:08:43 Here's the output:
10:08:43 time="2021-05-10T15:08:41Z" level=error msg="HEADER map[Content-Length:[185] Content-Type:[text/html] Date:[Mon, 10 May 2021 15:08:41 GMT] Server:[nginx/1.12.1]]"
10:08:43 {
10:08:43     "Name": "quay.io/app-sre/aws-account-operator",
10:08:43     "Digest": "sha256:02baefe6abe17a60f9751441fdd7223b3d79af5580639d4ea90285bbab28a0c7",

For some reason, skopeo inspect is now producing that header information on stderr, whereas it wasn't before.

Nevertheless, that's no excuse for glomming together stdout and stderr when we expect to be able to parse the former. So with this commit, we split stderr out and redirect it to a temporary file instead.

commit: 9f62838f2f7eba3573d83400d2b227655f71b399 author: Eric Fried Support building multiple images

Previously the app-sre pipeline scripts were designed to build/push (if not already extant) exactly two things: the operator image and the OLM catalog.

With this commit we allow the consumer to build arbitrary images in addition to the operator image by setting a multiline make variable as follows:

define ADDITIONAL_IMAGE_SPECS
./path/to/a/Dockerfile $(IMAGE_REGISTRY)/$(IMAGE_REPOSITORY)/a-image:v1.2.3
./path/to/b/Dockerfile $(IMAGE_REGISTRY)/$(IMAGE_REPOSITORY)/b-image:v4.5.6
endef

NOTE: As an ancillary side effect (benefit) of this commit, we stop tagging latest operator images. They were unused at best, misused at worst.

commit: cc2ba9070df73175397f4d36ffeaadae073d240f author: Eric Fried Add splunk-forwarder-operator as a subscriber

commit: f03b007a8a2bb12183b611ed231cef5a82ef8f7d author: Christoph Blecker Use /usr/bin/env bash everywhere

commit: bf324c0b4fbf95930caf2613f60f362bc32e8469 author: Dominic Finn help to makefile

commit: 06e3d461cbccc2f73bd2b67a8e6173def1ccb2eb author: Christoph Blecker Make sed prompt to use compatible sed

commit: 29ea0a0182e40bed2d90c162b084e96d6643c75a author: Eric Fried Subscriber updates

All registered operators are onboarded at this point.

commit: 01138a140ecac9b3c761408c5f75d667e9a0ff52 author: Dominic Finn Update boilerplate/_lib/container-make

Co-authored-by: Eric Fried 2uasimojo@users.noreply.github.com

commit: 1d066c78317c923381571167f98e53f44478f01c author: Dominic Finn podman build logic

commit: 4a28e9b440b478795346b68bc2c8a0d6f29deee2 author: Christoph Blecker Fix codecov job errors

commit: 5522c6bdcda11035e975bcf7898e1709950f2792 author: Christoph Blecker Persist codecov script used as a test artifact

commit: 12e79262e14bd97051e12c34ef4a11ecfd958764 author: Kirk Bater removes debug flag from container-make

commit: 994bbe4f92687be3a386fe26ee28331c8f1c07cb author: Arjun Naik Error when unsupported resources present

Signed-off-by: Arjun Naik anaik@redhat.com

commit: 63afc0b627ce08a08abe95b9e5b62440ff1d3dba author: Eric Fried app-sre.md: Remove references to REGISTRY_USER/_TOKEN

These are no longer necessary since 272a910

commit: 9d00c82de0a3c05d3d3d0864d9196640df11472f author: Benjamin Dematteo enabling back codecov as we are clear from the incident

iamkirkbater commented 3 years ago

Nothing here looks like it should change any functionality other than build functionality, so this

/lgtm

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment