search

openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Improve STS related docs #576

Closed dastergon closed 3 years ago

dastergon commented 3 years ago

After some troubleshooting around STS, I realized that some areas need an update to reflect the latest STS changes. I updated the configmap generation script and the docs.

Needs #574 to be merged first

PTAL

codecov-commenter commented 3 years ago

Codecov Report

Merging #576 (63c9654) into master (b26c233) will decrease coverage by 0.30%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #576      +/-   ##
==========================================
- Coverage   13.76%   13.46%   -0.31%     
==========================================
  Files          45       44       -1     
  Lines        3741     3774      +33     
==========================================
- Hits          515      508       -7     
- Misses       3203     3243      +40     
  Partials       23       23
Impacted Files Coverage Δ
cmd/manager/main.go 0.00% <ø> (ø)
pkg/apis/addtoscheme_aws_v1alpha1.go 100.00% <ø> (ø)
pkg/apis/apis.go 100.00% <ø> (ø)
pkg/apis/aws/v1alpha1/account_types.go 90.47% <ø> (ø)
pkg/apis/aws/v1alpha1/accountclaim_types.go 8.33% <0.00%> (ø)
pkg/apis/aws/v1alpha1/accountpool_types.go 100.00% <ø> (ø)
...is/aws/v1alpha1/awsfederatedaccountaccess_types.go 100.00% <ø> (ø)
pkg/apis/aws/v1alpha1/awsfederatedrole_types.go 100.00% <ø> (ø)
pkg/apis/aws/v1alpha1/register.go 0.00% <ø> (ø)
pkg/awsclient/client.go 0.00% <0.00%> (ø)
... and 28 more
dastergon commented 3 years ago

@iamkirkbater I've updated the PR with your suggestions! Thanks :) PTAL

dastergon commented 3 years ago

/test images

iamkirkbater commented 3 years ago

This looks great! Feel free to remove the hold on monday after #574 is merged and let this one merge in.

/lgtm /hold

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dastergon commented 3 years ago

/hold cancel