dkeohane commented 3 years ago

Now calling createBYOCAdminAccessRole for all non-STS accounts within the account_controller.go
Removed existing call to createBYOCAdminAccessRole from byoc.go in lieu of the change above.
To Note: the big if block added to account_controller.go could be refactored down even further if we did not have the dependency on the RoleID within the assumeRole func - there's an outstanding question over its use, therefore this refactor may still occur

codecov-commenter commented 3 years ago

Codecov Report

Merging #582 (f84a1dd) into master (84b11dd) will increase coverage by 2.30%. The diff coverage is 22.82%.

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
+ Coverage   20.17%   22.48%   +2.30%     
==========================================
  Files          46       46              
  Lines        4426     4457      +31     
==========================================
+ Hits          893     1002     +109     
+ Misses       3472     3382      -90     
- Partials       61       73      +12

Impacted Files	Coverage Δ
pkg/controller/account/account_controller.go	`9.14% <0.00%> (+2.80%)`	:arrow_up:
pkg/controller/account/byoc.go	`61.62% <100.00%> (+23.48%)`	:arrow_up:
pkg/controller/utils/conditions.go	`22.35% <0.00%> (+11.17%)`	:arrow_up:
pkg/apis/aws/v1alpha1/accountclaim_types.go	`45.00% <0.00%> (+35.00%)`	:arrow_up:
pkg/controller/utils/status.go	`91.66% <0.00%> (+45.83%)`	:arrow_up:

lisa commented 3 years ago

/retest

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dastergon, dkeohane, lisa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [lisa] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift / aws-account-operator

[OSD-7072] Adding new role to non-STS accounts #582

Codecov Report