Closed 2uasimojo closed 3 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: 2uasimojo
To complete the pull request process, please assign jharrington22 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jharrington22
in a comment when ready.
The full list of commands accepted by this bot can be found here.
Depends-On: https://github.com/openshift/release/pull/18898
/retest
Merging #588 (55c9da6) into master (9ab93e1) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head 55c9da6 differs from pull request most recent head 3ad21ad. Consider uploading reports for the commit 3ad21ad to get more accurate results
@@ Coverage Diff @@
## master #588 +/- ##
=======================================
Coverage 13.18% 13.18%
=======================================
Files 45 45
Lines 3906 3906
=======================================
Hits 515 515
Misses 3368 3368
Partials 23 23
Impacted Files | Coverage Δ | |
---|---|---|
pkg/apis/aws/v1alpha1/account_types.go | 90.47% <ø> (ø) |
|
pkg/apis/aws/v1alpha1/accountclaim_types.go | 5.88% <ø> (ø) |
|
pkg/apis/aws/v1alpha1/accountpool_types.go | 100.00% <ø> (ø) |
Trivial rebase
@2uasimojo: The following test failed, say /retest
to rerun all failed tests:
Test name | Commit | Details | Rerun command |
---|---|---|---|
ci/prow/validate | 55c9da6f7714e381d8856b5979b77c0ccc7628c5 | link | /test validate |
Full PR test history. Your PR dashboard.
/assign @iamkirkbater
@2uasimojo: PR needs rebase.
This will now need to be reconciled with #580. I think we should just be able to revert the last four commits.
@2uasimojo how can we proceed here?
I'm working with @sam-nguyen7.
I've finished rebasing and cleaning up #589, which supersedes this, so we can close.
This PR comprises three commits:
.gitattributes
. (Suppression is not included in this PR.)See individual commit messages for details.