openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive
Apache License 2.0
32 stars 75 forks source link

Boilerplate update removing `operator-sdk generate` #588

Closed 2uasimojo closed 3 years ago

2uasimojo commented 3 years ago

This PR comprises three commits:

See individual commit messages for details.

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 2uasimojo To complete the pull request process, please assign jharrington22 after the PR has been reviewed. You can assign the PR to them by writing /assign @jharrington22 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
2uasimojo commented 3 years ago

Depends-On: https://github.com/openshift/release/pull/18898

2uasimojo commented 3 years ago

/retest

codecov-commenter commented 3 years ago

Codecov Report

Merging #588 (55c9da6) into master (9ab93e1) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 55c9da6 differs from pull request most recent head 3ad21ad. Consider uploading reports for the commit 3ad21ad to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master     #588   +/-   ##
=======================================
  Coverage   13.18%   13.18%           
=======================================
  Files          45       45           
  Lines        3906     3906           
=======================================
  Hits          515      515           
  Misses       3368     3368           
  Partials       23       23           
Impacted Files Coverage Δ
pkg/apis/aws/v1alpha1/account_types.go 90.47% <ø> (ø)
pkg/apis/aws/v1alpha1/accountclaim_types.go 5.88% <ø> (ø)
pkg/apis/aws/v1alpha1/accountpool_types.go 100.00% <ø> (ø)
2uasimojo commented 3 years ago

Trivial rebase

openshift-ci[bot] commented 3 years ago

@2uasimojo: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/validate 55c9da6f7714e381d8856b5979b77c0ccc7628c5 link /test validate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
lisa commented 3 years ago

/assign @iamkirkbater

openshift-ci[bot] commented 3 years ago

@2uasimojo: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
2uasimojo commented 3 years ago

This will now need to be reconciled with #580. I think we should just be able to revert the last four commits.

dastergon commented 3 years ago

@2uasimojo how can we proceed here?

2uasimojo commented 3 years ago

I'm working with @sam-nguyen7.

I've finished rebasing and cleaning up #589, which supersedes this, so we can close.