openshift / aws-account-operator

Operator to manage pool of AWS accounts for Hive

Apache License 2.0

32 stars 75 forks source link

Ensure region in the AccountClaim is returned from DescribeRegions API call #595

Closed ArielLima closed 3 years ago

ArielLima commented 3 years ago

The AWS account operator will call DescribeRegions to gather a list of regions to initialize when setting up a AWS account. If a user chooses one of the 4 opt-in regions but hasn't enabled it in AWS the region will not be returned by the DescribeRegions AWS API call and we want to fail.

Card: https://issues.redhat.com/browse/OSD-7417

ArielLima commented 3 years ago

@jharrington22

codecov-commenter commented 3 years ago

Codecov Report

Merging #595 (12b4016) into master (7a9a581) will decrease coverage by 0.08%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #595      +/-   ##
==========================================
- Coverage   13.25%   13.17%   -0.09%     
==========================================
  Files          45       45              
  Lines        3884     3908      +24     
==========================================
  Hits          515      515              
- Misses       3346     3370      +24     
  Partials       23       23

Impacted Files	Coverage Δ
pkg/controller/account/account_controller.go	`0.32% <0.00%> (-0.02%)`	:arrow_down:
pkg/controller/account/ec2.go	`0.00% <0.00%> (ø)`

ArielLima commented 3 years ago

/label tide/merge-method-squash

iamkirkbater commented 3 years ago

/lgtm

Thanks!

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArielLima, iamkirkbater

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/aws-account-operator/blob/master/OWNERS)~~ [iamkirkbater] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment